Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7008 - Fix regression in bin/jetty.sh on systems using start-stop-daemon #7009

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Oct 18, 2021

  • Using start-stop-daemon options properly
  • Do not include JETTY_SYS_PROPS in JAVA_OPTIONS to avoid duplicates that show up in RUN_ARGS.
  • Only use JETTY_SYS_PROPS in RUN_CMD.

+ Minor fix to remove extra LF output in RUN_ARGS
+ Using start-stop-daemon options properly

Signed-off-by: Joakim Erdfelt <[email protected]>
+ Do not include JETTY_SYS_PROPS in JAVA_OPTIONS
  to avoid duplicates that show up in RUN_ARGS.
+ Only use JETTY_SYS_PROPS in RUN_CMD.

Signed-off-by: Joakim Erdfelt <[email protected]>
@joakime joakime self-assigned this Oct 18, 2021
@joakime joakime added the Bug For general bugs on Jetty side label Oct 18, 2021
@joakime joakime requested a review from gregw October 20, 2021 11:13
@joakime joakime changed the title Issue #7008 - Update bin/jetty.sh Issue #7008 - Fix regression in bin/jetty.sh on systems using start-stop-daemon Oct 20, 2021
@joakime
Copy link
Contributor Author

joakime commented Oct 20, 2021

The issue filer has verified that this works for them. #7008 (comment)

@joakime joakime requested a review from olamy October 21, 2021 22:56
@joakime joakime merged commit cdf03fe into jetty-10.0.x Oct 22, 2021
@joakime joakime deleted the jetty-10.0.x-7008-updated-jetty-sh branch February 11, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with jetty.sh start regression 10.0.6 -> 10.0.7 when using JETTY_USER
2 participants