Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6186 - Add null protection to Log/Logger API #6187

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Issue #6186 - Add null protection to Log/Logger API #6187

merged 1 commit into from
Apr 21, 2021

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Apr 16, 2021

Signed-off-by: Joakim Erdfelt [email protected]

@joakime joakime self-assigned this Apr 16, 2021
@gregw
Copy link
Contributor

gregw commented Apr 17, 2021

You'll need a PR to cherry pick this to 10.

@joakime
Copy link
Contributor Author

joakime commented Apr 21, 2021

You'll need a PR to cherry pick this to 10.

Since Jetty 10 uses slf4j-api, I don't think this extra work is necessary.
But I'll double check our implementation anyway.

@joakime joakime merged commit b15b37f into jetty-9.4.x Apr 21, 2021
@joakime joakime deleted the jetty-9.4.x-6186-no-null-logger branch April 21, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@olamy olamy olamy approved these changes

Assignees

@joakime joakime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joakime @gregw @olamy