Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #6072 - jetty server high CPU when client sends TLS record length > 17408 (jetty-9.4.x) #6073

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Fixes #6072 - jetty server high CPU when client sends TLS record length > 17408 (jetty-9.4.x) #6073

merged 2 commits into from
Mar 22, 2021

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Mar 18, 2021

…408.

Avoid spinning if the input buffer is full.

Signed-off-by: Simone Bordet [email protected]
Co-authored-by: Joakim Erdfelt [email protected]

@joakime @sbordet
Fixes #6072 - jetty server high CPU when client send data length > 17…
af289dc 
…408.

Avoid spinning if the input buffer is full.

Signed-off-by: Simone Bordet <[email protected]>
Co-authored-by: Joakim Erdfelt <[email protected]>
@sbordet sbordet requested a review from joakime March 18, 2021 15:07
@joakime joakime added the Bug For general bugs on Jetty side label Mar 18, 2021
@sbordet sbordet mentioned this pull request Mar 18, 2021
Merged
@joakime joakime changed the title Fixes #6072 - jetty server high CPU when client send data length > 17… Fixes #6072 - jetty server high CPU when client send data length > 17408 (jetty-9.4.x) Mar 18, 2021
@joakime joakime linked an issue Mar 18, 2021 that may be closed by this pull request
High CPU usage when TLS client sends TLS Record data exceeding length 17408 #6072
Closed
@joakime joakime changed the title Fixes #6072 - jetty server high CPU when client send data length > 17408 (jetty-9.4.x) Fixes #6072 - jetty server high CPU when client sends TLS record length > 17408 (jetty-9.4.x) Mar 18, 2021
gregw
gregw requested changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind.... I think we should check the size on any zero fill, not just the last non zero

@sbordet
Fixes #6072 - jetty server high CPU when client send data length > 17…
705e5e9 
…408.

Updates after review.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet requested a review from gregw March 22, 2021 09:48
@sbordet sbordet merged commit 294b2ba into jetty-9.4.x Mar 22, 2021
@sbordet sbordet deleted the jetty-9.4.x-6072-ssl-cpuspin branch March 22, 2021 22:24
@joakime joakime mentioned this pull request Apr 1, 2021
Closed
@cxronen cxronen mentioned this pull request Mar 4, 2022
Open
@cxronen cxronen mentioned this pull request Sep 20, 2022
Closed
@cxronen cxronen mentioned this pull request Dec 20, 2022
Open
@cxronen cxronen mentioned this pull request Feb 17, 2023
Open
@cxronen cxronen mentioned this pull request Nov 22, 2022
Open
@AASMACMX AASMACMX mentioned this pull request Feb 26, 2023
Open
@cxronen cxronen mentioned this pull request Apr 13, 2023
Open
@cxronen cxronen mentioned this pull request May 25, 2023
Open
@AASMACMX AASMACMX mentioned this pull request Jul 20, 2023
Open
@cxronen cxronen mentioned this pull request Feb 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@joakime joakime Awaiting requested review from joakime

Assignees
No one assigned
Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

High CPU usage when TLS client sends TLS Record data exceeding length 17408
3 participants
@sbordet @gregw @joakime