Fixes #5994 - QueuedThreadPool "free" threads #5995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced to QueuedThreadPool: * getMaxReservedThreads() * getAvailableReservedThreads() * getAvailableThreads() * getReadyThreads() * getLeasedThreads() Also few small code cleanups. Signed-off-by: Simone Bordet <[email protected]>
gregw
requested changes
Feb 23, 2021
There was a problem hiding this comment.
Updated from my comment on the issue...
We need a good vocab to describe all the states a thread can be in and then matching getters and JMX fields:
- inactive: not started but there is capacity to start another thread
- idle: started and waiting in the pool for a task
- reserved: taken from the pool but reserved to do a task
- leased: taken from the pool to do a (budgeted - maxReserved) task like selecting
- utilised: taken from the pool for a non-leased task.
So we have some invariants and derived stats:
max = inactive + idle + reserved + leased + utilised
threads = idle + reserved + leased + utilised
busy = leased + utilised
ready = idle + reserved
utilised = threads - idle - reserved - leased
available = max - busy
maxAvailable = max - leased
utilisation = utilised / maxAvailable # 0.0 means idle, 1.0 means at capacity
gregw
requested changes
Feb 23, 2021
jetty-util/src/main/java/org/eclipse/jetty/util/thread/QueuedThreadPool.java
Outdated
Show resolved
Hide resolved
jetty-util/src/main/java/org/eclipse/jetty/util/thread/QueuedThreadPool.java
Show resolved
Hide resolved
Updates after review. Signed-off-by: Simone Bordet <[email protected]>
|
I'm keen to +1 this PR just because it's javadoc'd! :-) |
gregw
approved these changes
Feb 23, 2021
This was referenced Mar 10, 2021
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced to QueuedThreadPool:
Also few small code cleanups.
Signed-off-by: Simone Bordet [email protected]