Issue #5950 - remove WebAppClassLoader logging during loadClass

[joakime]

Signed-off-by: Joakim Erdfelt [email protected]

[janbartel]

Such a pity this seems to be necessary: when things are really going wrong it was so helpful to turn on debug logging for the WebAppClassLoader and find out how classes were being loaded (or not).

[olamy]

@joakime @janbartel if it's so helpful could we have something such -Djetty.classloader.debug=true and replace those LOG.debug with System.err/out?
Or something such

private static final boolean DEBUG = System.getBoolean("jetty.classloader.debug")
then in code where we need it
if (DEBUG) 
   System.out/err
or (maybe more complicated)
  org.eclipse.jetty.util.log.Logger.getLogger(...).debug("")

[gregw]

LGTM other than a few niggles.

[gregw]

Probably should be e.printStackTrace() to replace warnings

[gregw]

Is it possible to test if -verbose:class is set, then we could do some stderr logging if it is? But I'm still good with this and we can add in stderr logging if/when necessary

[joakime]

Sorry, this isn't ready.
There's still logging occurring during load class.

[joakime]

Sorry, the draft status was in error.
The extra logging I saw was not during loadClass.
Will merge shortly.

[jglick]

in https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.37.v20210219 FTR