Issue #5032 - Minimal Extensible Web App changes #5273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakime
added
Enhancement
Sponsored
gregw
requested changes
Sep 16, 2020
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/FilterHolder.java
Outdated
Show resolved
Hide resolved
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/FilterHolder.java
Outdated
Show resolved
Hide resolved
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/ListenerHolder.java
Outdated
Show resolved
Hide resolved
|
@gregw branch updated based on your review. |
joakime
commented
Sep 16, 2020
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/FilterHolder.java
Outdated
Show resolved
Hide resolved
joakime
commented
Sep 16, 2020
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/ListenerHolder.java
Outdated
Show resolved
Hide resolved
joakime
commented
Sep 16, 2020
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/ServletHolder.java
Outdated
Show resolved
Hide resolved
gregw
reviewed
Sep 16, 2020
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/BaseHolder.java
Outdated
Show resolved
Hide resolved
gregw
approved these changes
Sep 16, 2020
gregw
requested changes
Sep 16, 2020
|
Once I get all clear from CI, I'll merge. |
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime
force-pushed
the
jetty-9.4.x-5032-minimal-extensible-web-apps
branch
from
d08831b
to
59976dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing PR #5033 as a minimal set of changes to allow for extensible Web Apps.
Either as WebAppContext or a ServletContextHandler.
Signed-off-by: Joakim Erdfelt [email protected]