Issue #5105 - StatisticsHandler Graceful Shutdown of Async Requests #5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Draebing <[email protected]>
If the request is async dispatched, the check state.isSuspended() is not correct to determine if the request was async or not. The check state.isAsyncStarted() should be used instead. Signed-off-by: Lachlan Roberts <[email protected]>
…quests in StatisticsHandler Signed-off-by: Lachlan Roberts <[email protected]>
StatisticsHandler no longer gives 503 responses after shutdown. Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts
changed the title
lachlan-roberts
commented
Aug 19, 2020
jetty-server/src/test/java/org/eclipse/jetty/server/GracefulStopTest.java
Outdated
Show resolved
Hide resolved
gregw
requested changes
Aug 22, 2020
jetty-server/src/main/java/org/eclipse/jetty/server/handler/StatisticsHandler.java
Show resolved
Hide resolved
jetty-server/src/test/java/org/eclipse/jetty/server/GracefulStopTest.java
Outdated
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/handler/StatisticsHandler.java
Outdated
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/handler/StatisticsHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
reviewed
Aug 24, 2020
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
approved these changes
Aug 25, 2020
sbordet
requested changes
Aug 25, 2020
jetty-server/src/main/java/org/eclipse/jetty/server/handler/StatisticsHandler.java
Outdated
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/handler/StatisticsHandler.java
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts
force-pushed
the
jetty-9.4.x-5105-StatisticsHandler
branch
from
d09055b
to
a9c90d3
Compare
sbordet
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5105
I have rebased this PR onto the branch from PR #5173 from @thomasdraebing.
If an async request has already started we do not properly add the
AsyncListenerto theHttpChannelStateand instead treat it as a completed blocking request even though it has not completed. This is because we used the checkstate.isSuspended()instead ofstate.isAsyncStarted().This PR also adds an optional configuration to not wait for the suspended requests when doing a graceful shutdown, but instead shutdown when there are no actively dispatched requests. This can be used as a setter on
StatisticsHandleror by an ini property onstats.mod.