Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1100 - ensure init and destroy are always called on JSR356 Encoders #4987

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Issue #1100 - ensure init and destroy are always called on JSR356 Encoders #4987

merged 2 commits into from
Jun 22, 2020

Conversation

lachlan-roberts
Copy link
Contributor

closes #1100

@lachlan-roberts lachlan-roberts mentioned this pull request Jun 22, 2020
Closed
joakime
joakime approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge it.

@lachlan-roberts lachlan-roberts merged commit 1b59672 into jetty-9.4.x Jun 22, 2020
@lachlan-roberts lachlan-roberts deleted the jetty-9.4.x-1100-WebSocketEncoderLifeCycle branch June 22, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lachlan-roberts @joakime