Fixing OpenWebBeans test on Jetty 10.0.x #4706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorban
reviewed
Mar 24, 2020
...t-owb-cdi-webapp/src/main/java/org/eclipse/jetty/cdi/owb/OwbServletContainerInitializer.java
Outdated
Show resolved
Hide resolved
|
Are you sure the SCI is needed? If so, why? Why doesn't using their org.apache.webbeans.servlet.WebBeansConfigurationListener work instead? |
joakime
commented
Mar 24, 2020
tests/test-webapps/test-owb-cdi-webapp/src/main/webapp/WEB-INF/jetty-env.xml
Outdated
Show resolved
Hide resolved
|
@janbartel @lorban please re-review. |
|
For those wanting to know more about the CDI integrations, it is worthwhile reading #3804 and the PRs and other issues linked from it. The CDI integrations in both Weld and OWB were essentially calling internal interfaces to get their decorators registered. I created some more generic ways of integrating CDI... unfortunately OWB and Weld couldn't agree on the best way, so we ended up with two new integrations, plus some legacy support in 9.4 |
gregw
reviewed
Mar 24, 2020
joakime
changed the title
|
@gregw updated the title, and cleaned up the fix a bit too (using init-param, not system property now) |
gregw
approved these changes
Mar 25, 2020
tests/test-webapps/test-owb-cdi-webapp/src/main/webapp/WEB-INF/jetty-env.xml
Show resolved
Hide resolved
janbartel
approved these changes
Mar 25, 2020
+ OWB needs init-parameter to allow it's own ServletContainerInitializer found at org.apache.webbeans.servlet.WebBeansConfigurationListener$Auto to execute and properly add the required Listener for OWB to function. + See OWB-1296 Signed-off-by: Joakim Erdfelt <[email protected]>
joakime
force-pushed
the
jetty-10.0.x-restore-owb-hack
branch
from
df2eb86
to
f3bd661
Compare
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joakim Erdfelt [email protected]