Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #4628 - Non-Required Module Dependency Support #4629

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Issue #4628 - Non-Required Module Dependency Support #4629

merged 1 commit into from
Mar 3, 2020

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Mar 2, 2020

Signed-off-by: Joakim Erdfelt [email protected]

@joakime joakime requested a review from sbordet March 2, 2020 16:14
@joakime joakime self-assigned this Mar 2, 2020
@joakime joakime linked an issue Mar 2, 2020 that may be closed by this pull request
Add support for conditional module dependencies in jetty-start #4628
Closed
@joakime joakime merged commit f150062 into jetty-9.4.x Mar 3, 2020
@joakime joakime deleted the jetty-9.4.x-4628-optional-depends branch March 3, 2020 17:44
@joakime joakime mentioned this pull request Mar 3, 2020
Closed
@gregw
Copy link
Contributor

gregw commented Mar 9, 2020

I think this duplicates the existing [optional] mechanism and should be reverted

@gregw
Copy link
Contributor

gregw commented Mar 9, 2020

As explained in the issue #4628, the problem with this PR is the Non-Required name rather than the mechanism itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

Assignees

@joakime joakime

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for conditional module dependencies in jetty-start
3 participants
@joakime @gregw @sbordet