Issue #4537 - fix potential spin when discarding in WebSocketConnection #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts
force-pushed
the
jetty-9.4.x-4537-WebSocketSpin
branch
from
418aa0c to
20621b7
Compare
joakime
requested changes
Feb 11, 2020
|
@joakime I managed to replicate the spin by changing some methods and fields to public but it proved extremely difficult to reproduce in a unit test. Triggering the spin is hard enough and then you need to detect that one thread is still spinning even though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lachlan Roberts [email protected]
#4537