Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #4217 - (9.2.x) SslConnection DecryptedEndpoint flush eternal busy loop #4256

Merged
merged 5 commits into from
Oct 31, 2019
Merged

Issue #4217 - (9.2.x) SslConnection DecryptedEndpoint flush eternal busy loop #4256

merged 5 commits into from
Oct 31, 2019

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Oct 30, 2019

This is the jetty-9.2.x backport of Issue #4217

Signed-off-by: Joakim Erdfelt [email protected]

@joakime joakime added Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement labels Oct 30, 2019
@joakime joakime requested review from gregw and sbordet October 30, 2019 20:32
@joakime joakime changed the title Issue #4217 - SslConnection DecryptedEndpoint flush eternal busy loop Issue #4217 - (9.2.x) SslConnection DecryptedEndpoint flush eternal busy loop Oct 30, 2019
sbordet
sbordet approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backport of the SslConnection fixes looks good, but there are apparently unrelated WebSocket changes. Is there any reason for those? If not, I feel better they are removed, also because they only affect testing.

@joakime
Copy link
Contributor Author

joakime commented Oct 31, 2019

The websocket change is just to allow the codebase to compile.

See commit c980e3d

@joakime joakime merged commit 3722266 into jetty-9.2.x Oct 31, 2019
@joakime joakime deleted the jetty-9.2.x-tls-large-record branch October 31, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

@gregw gregw Awaiting requested review from gregw

Assignees
No one assigned
Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joakime @sbordet