Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0.x: Fix CachingHttpContentFactory$CachedHttpContent already released buffer #12710

Merged

Conversation

lorban
Copy link
Contributor

@lorban lorban commented Jan 14, 2025

Atomically retain the buffer with a check that it still is in the cache, otherwise delegate to the wrapped content.

Fixes #12681

Replaces / reverts #12702

…the cache, otherwise retain fails + remove single-threaded shrinking

Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban added the Bug For general bugs on Jetty side label Jan 14, 2025
@lorban lorban requested review from gregw and sbordet January 14, 2025 09:40
@lorban lorban self-assigned this Jan 14, 2025
@lorban
Copy link
Contributor Author

lorban commented Jan 14, 2025

This is a backport of #12704

@lorban lorban merged commit 19214f7 into jetty-12.0.x Jan 15, 2025
10 checks passed
@lorban lorban deleted the fix/jetty-12.0.x/12681-cached-content-already-released branch January 15, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

CachingHttpContentFactory$CachedHttpContent already released buffer
2 participants