Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12023 - Remove WriteFlusher.Listener. #12065

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Jul 19, 2024

WriteFlusher.Listener functionality was removed, and the class deprecated in 12.0.10 as part of the work for #9778 and #11839.

WriteFlusher.Listener functionality was removed, and the class deprecated in 12.0.10 as part of the work for #9778 and #11839.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet requested review from gregw and lorban July 19, 2024 19:08
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've kicked of another CI run as it looks like jenkins stopped.

Copy link
Contributor

@lorban lorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks a test that should be investigated, otherwise LGTM.

@sbordet sbordet merged commit f154f21 into jetty-12.1.x Jul 29, 2024
10 checks passed
@sbordet sbordet deleted the fix/jetty-12.1.x/remove-writeflusher-listener branch July 29, 2024 09:33
@olamy olamy mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants