Jetty 12.0.x object identity ee8 and ee9 #11888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregw
requested changes
Jun 11, 2024
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/ContextHandler.java
Show resolved
Hide resolved
...-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/CrossContextDispatcher.java
Outdated
Show resolved
Hide resolved
...-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/CrossContextDispatcher.java
Outdated
Show resolved
Hide resolved
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/SessionHandler.java
Show resolved
Hide resolved
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/SessionHandler.java
Show resolved
Hide resolved
…/nested/CrossContextDispatcher.java Co-authored-by: Greg Wilkins <[email protected]>
+ Removed JSON + Collapsed Steps + Simplified plan text
gregw
previously approved these changes
Jun 11, 2024
…-2' into jetty-12.0.x-object-identity-ee8-and-ee9
…-2' into jetty-12.0.x-object-identity-ee8-and-ee9
…oss-context-testing-2
…-2' into jetty-12.0.x-object-identity-ee8-and-ee9
|
@gregw can I get a re-review? The jenkins failure is nothing to do with this PR, its a HTTP2 test failure. |
…object-identity-ee8-and-ee9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to maintain object wrapper identity during cross context dispatch, only for ee8 & 9.