Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the rewrite Jetty module. #11686

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Document the rewrite Jetty module. #11686

merged 2 commits into from
Apr 24, 2024

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Apr 23, 2024

No description provided.

gregw
gregw previously approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK.
But would be nice to be able to generate a list of links to the javadoc of all the rule classes (or maybe just the package?).

@sbordet
Added link to list of rules.
611f8c8 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Copy link
Contributor Author

sbordet commented Apr 24, 2024

@gregw I have added a link to the list of rules, pointing to the javadocs of the package (which lists all the classes).

@sbordet sbordet merged commit e491fc3 into jetty-12.0.x Apr 24, 2024
2 of 4 checks passed
@sbordet sbordet deleted the fix/jetty-12/document-rewrite-module branch April 24, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw left review comments

@joakime joakime Awaiting requested review from joakime

@jmcc0nn3ll jmcc0nn3ll Awaiting requested review from jmcc0nn3ll

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 12.0.9 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbordet @gregw