Issue #11648 - Introducing HttpDateTime class. #11672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Introduces HTTP (and Cookie) Date/Time parsing according to spec algorithms. + Introduces formatting according to spec mandated preferred RFC 1123 format. + Deprecate DateParser
|
As of commit f101889 these are the performance numbers. The |
joakime
added
the
Specification
This was referenced Apr 19, 2024
gregw
requested changes
Apr 22, 2024
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpDateTime.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpDateTime.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpDateTime.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpDateTime.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpDateTime.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpDateTime.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpDateTime.java
Outdated
Show resolved
Hide resolved
gregw
requested changes
Apr 22, 2024
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpDateTime.java
Outdated
Show resolved
Hide resolved
sbordet
requested changes
Apr 22, 2024
| continue; // skip blank tokens | ||
|
|
||
| // RFC 6265 - Section 5.1.1 - Step 2.1 - time (00:00:00) | ||
| if (hour == (-1) && token.length() == 8 && token.charAt(2) == ':' && token.charAt(5) == ':') |
There was a problem hiding this comment.
Please get rid of parens around -1 everywhere.
gregw
requested changes
Apr 23, 2024
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpDateTime.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpDateTime.java
Outdated
Show resolved
Hide resolved
sbordet
previously approved these changes
Apr 23, 2024
sbordet
previously approved these changes
Apr 23, 2024
sbordet
approved these changes
Apr 23, 2024
gregw
reviewed
Apr 23, 2024
| */ | ||
| public static String format(TemporalAccessor datetime) | ||
| { | ||
| return DateTimeFormatter.RFC_1123_DATE_TIME |
There was a problem hiding this comment.
Oh interesting! IT does the hard coded "GMT" for us, even if we pass in "UTC". Nice! Well not nice... ugly history in evidence... but at least it is consistent. The time is in UTC, but just reported as "GMT"!
gregw
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This an alternative implementation for PR #11658
Fixes: #11648