Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #11574 war should not be extracted unless configured to do so #11575

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Issue #11574 war should not be extracted unless configured to do so #11575

merged 3 commits into from
Mar 27, 2024

Conversation

janbartel
Copy link
Contributor

Closes #11574

@janbartel janbartel added the Bug For general bugs on Jetty side label Mar 26, 2024
@janbartel janbartel self-assigned this Mar 26, 2024
@janbartel janbartel mentioned this pull request Mar 26, 2024
Closed
joakime
joakime requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvements in code

jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/resource/Resource.java Outdated Show resolved Hide resolved
...-ee10/jetty-ee10-webapp/src/main/java/org/eclipse/jetty/ee10/webapp/WebInfConfiguration.java Outdated Show resolved Hide resolved
...-ee10/jetty-ee10-webapp/src/main/java/org/eclipse/jetty/ee10/webapp/WebInfConfiguration.java Outdated Show resolved Hide resolved
lorban
lorban requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@lorban lorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides Resource.COMPARATOR_BY_NAME, LGTM.

jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/resource/Resource.java Outdated Show resolved Hide resolved
joakime
joakime previously approved these changes Mar 26, 2024
View reviewed changes
lorban
lorban previously approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@lorban lorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny nit left: there's one lookingly useless import to remove; otherwise LGTM.

jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/resource/Resource.java Outdated
@@ -26,6 +26,7 @@
import java.time.Instant;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Comparator;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unneeded import?

gregw
gregw previously approved these changes Mar 26, 2024
View reviewed changes
@janbartel janbartel dismissed stale reviews from gregw, lorban, and joakime via 69ef33e March 27, 2024 09:01
@janbartel janbartel merged commit 94beede into jetty-12.0.x Mar 27, 2024
2 of 4 checks passed
@janbartel janbartel deleted the jetty-12.0.x-11574-war-extraction branch March 27, 2024 09:02
sbordet pushed a commit that referenced this pull request Mar 28, 2024
@janbartel @sbordet
Issue #11574 war should not be extracted unless configured to do so (#…
302ae64 
…11575)

* Issue #11574 war should not be extracted unless configured to do so
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorban lorban lorban left review comments

@joakime joakime joakime left review comments

@gregw gregw gregw left review comments

Assignees

@janbartel janbartel

Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 12.0.8 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shibboleth idp webapp under jetty 12.0.7
4 participants
@janbartel @gregw @joakime @lorban