Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow override of jakarta.* container classes by webapps per Servlet 5.0 Section 15.2.1 #6125

Closed
joakime opened this issue Apr 2, 2021 · 1 comment · Fixed by #6126
Closed

Do not allow override of jakarta.* container classes by webapps per Servlet 5.0 Section 15.2.1 #6125

joakime opened this issue Apr 2, 2021 · 1 comment · Fixed by #6126
Assignees
@joakime
Labels
Bug For general bugs on Jetty side

Comments

@joakime
Copy link
Contributor

joakime commented Apr 2, 2021

Jetty version
11.0.x

Description
As identified in Issue #6123 the jakarta.* classes from the container can be overridden by a webapp.

This is incorrect per Servlet spec Section 15.2.1, and if the jakarta.* class exists in the container, the webapp shall not be allowed to override it.
@joakime joakime added the Bug For general bugs on Jetty side label Apr 2, 2021
@joakime joakime self-assigned this Apr 2, 2021
joakime added a commit that referenced this issue Apr 2, 2021
@joakime
Issue #6125 - Add jakarta.* to system classes defaults
49ecc3b 
Signed-off-by: Joakim Erdfelt <[email protected]>
@joakime joakime linked a pull request Apr 2, 2021 that will close this issue
Issue #6125 - Add jakarta.* to system classes defaults #6126
Merged
joakime added a commit that referenced this issue Apr 6, 2021
@joakime
Merge pull request #6126 from eclipse/jetty-11.0.x-systemclasses-jakarta
269d9b7 
Issue #6125 - Add jakarta.* to system classes defaults
@joakime
Copy link
Contributor Author

joakime commented Apr 12, 2021

PR #6126 merged.

@joakime joakime closed this as completed Apr 12, 2021
@gregw gregw mentioned this issue May 6, 2021
Closed
@olamy olamy mentioned this issue Jul 25, 2021
Merged
@olamy olamy mentioned this issue Sep 30, 2021
Merged
@olamy olamy mentioned this issue May 6, 2022
Merged
@olamy olamy mentioned this issue May 26, 2022
Merged
This was referenced Jul 25, 2022
Merged
Merged
Merged
@olamy olamy mentioned this issue Aug 13, 2022
Merged
@olamy olamy mentioned this issue Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #6125 - Add jakarta.* to system classes defaults jetty/jetty.project
1 participant
@joakime