HttpConnection.getBytesIn() incorrect for requests with chunked content #6105
Assignees
Comments
|
@bjorncs thanks for the report, we'll work on the Jetty issue. |
|
It's not a blocker - we only use the value for logging purposes at the moment. |
sbordet
added a commit
that referenced
this issue
Mar 26, 2021
… chunked content Moved recording of bytes to fillRequestBuffer(), so they are accounted also for async reads. Added test case. Signed-off-by: Simone Bordet <[email protected]>
sbordet
added a commit
that referenced
this issue
Mar 26, 2021
… chunked content Fixed test that was too strictly comparing HttpConnection.bytesIn, that now report a correct, but larger value. Signed-off-by: Simone Bordet <[email protected]>
sbordet
added a commit
that referenced
this issue
Apr 8, 2021
#6108) * Fixes #6105 - HttpConnection.getBytesIn() incorrect for requests with chunked content Moved recording of bytes to fillRequestBuffer(), so they are accounted also for async reads. Added test case. Fixed test that was too strictly comparing HttpConnection.bytesIn, that now report a correct, but larger value. Signed-off-by: Simone Bordet <[email protected]>
sbordet
added a commit
that referenced
this issue
Apr 8, 2021
… chunked content Moved recording of bytes to fillRequestBuffer(), so they are accounted also for async reads. Added test case. Fixed test that was too strictly comparing HttpConnection.bytesIn, that now report a correct, but larger value. Signed-off-by: Simone Bordet <[email protected]> (cherry picked from commit aed20ab)
|
Closing, as PR #6108 was merged. |
sbordet
added a commit
that referenced
this issue
Apr 10, 2021
… chunked content Moved recording of bytes to fillRequestBuffer(), so they are accounted also for async reads. Added test case. Fixed test that was too strictly comparing HttpConnection.bytesIn, that now report a correct, but larger value. Signed-off-by: Simone Bordet <[email protected]> (cherry picked from commit aed20ab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Jetty version
9.4.38.v20210224
Java version
11.0.7+10
OS type/version
MacOS 10.15.7
Description
HttpConnection.bytesInis only aggregated whenfillRequestBuffer()is called fromonFillable(), not fromfillAndParseForContent(). The result is thatHttpConnection.getBytesIn()reports a value lower than than the actual number of bytes filled. I have been able to reproduce this for POST requests using chunked encoding.The text was updated successfully, but these errors were encountered: