Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SslConnection compacting #6082

Closed
gregw opened this issue Mar 22, 2021 · 2 comments · Fixed by #6083 or #6142
Closed

SslConnection compacting #6082

gregw opened this issue Mar 22, 2021 · 2 comments · Fixed by #6083 or #6142

Comments

@gregw
Copy link
Contributor

gregw commented Mar 22, 2021

From fixing #6072, it became apparent that the SslConnection compacts buffers frequently. Performance can be improved if compaction is only done when needed.
gregw added a commit that referenced this issue Mar 22, 2021
@gregw
Fix #6082 Reduce SSL buffer compaction
09f39d7 
Only compact when buffer is underflown.  Note that BufferUtil will also do a cheap "compact" when flipping empty buffers.

Signed-off-by: Greg Wilkins <[email protected]>
@gregw gregw mentioned this issue Mar 22, 2021
Merged
gregw added a commit that referenced this issue Mar 23, 2021
@gregw
Fix #6082 Reduce SSL buffer compaction
485e561 
Only continue if compact creates more space

Signed-off-by: Greg Wilkins <[email protected]>
gregw added a commit that referenced this issue Mar 23, 2021
@gregw
Fix #6082 Reduce SSL buffer compaction (#6083)
96f707f 
Fix #6082 Reduce SSL buffer compaction
Only compact when buffer is underflown.  Note that BufferUtil will also do a cheap "compact" when flipping empty buffers.

Signed-off-by: Greg Wilkins <[email protected]>
@gregw
Copy link
Contributor Author

gregw commented Mar 23, 2021

This could be cherry picked back to 9 once it has proven stable in 10.

@gregw gregw reopened this Mar 23, 2021
gregw added a commit that referenced this issue Mar 24, 2021
@gregw
Fix #6082 Reduce SSL buffer compaction
86d4132 
fix test timeout

Signed-off-by: Greg Wilkins <[email protected]>
@gregw gregw mentioned this issue Apr 5, 2021
Closed
sbordet pushed a commit that referenced this issue Apr 6, 2021
@gregw @sbordet
Fix #6082 Reduce SSL buffer compaction (#6083)
0b13c52 
Fix #6082 Reduce SSL buffer compaction
Only compact when buffer is underflown.  Note that BufferUtil will also do a cheap "compact" when flipping empty buffers.

Signed-off-by: Greg Wilkins <[email protected]>
(cherry picked from commit 96f707f)
@sbordet sbordet mentioned this issue Apr 6, 2021
Merged
sbordet pushed a commit that referenced this issue Apr 7, 2021
@gregw @sbordet
Fix #6082 Reduce SSL buffer compaction (#6083)
58538c9 
Fix #6082 Reduce SSL buffer compaction
Only compact when buffer is underflown.  Note that BufferUtil will also do a cheap "compact" when flipping empty buffers.

Signed-off-by: Greg Wilkins <[email protected]>
(cherry picked from commit 96f707f)
@sbordet sbordet linked a pull request Apr 14, 2021 that will close this issue
Fix #6082 Reduce SSL buffer compaction (#6083) #6142
Merged
@sbordet
Copy link
Contributor

sbordet commented Apr 14, 2021

Fixed in Jetty 9 by #6142.

@sbordet sbordet closed this as completed Apr 14, 2021
@joakime joakime mentioned this issue Apr 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gregw @sbordet and others