Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demo-spec module incorrectly depends on demo-jndi #5360

Closed
janbartel opened this issue Sep 28, 2020 · 1 comment · Fixed by #5364
Closed

demo-spec module incorrectly depends on demo-jndi #5360

janbartel opened this issue Sep 28, 2020 · 1 comment · Fixed by #5364
Assignees
@joakime
Milestone
10.0.x

Comments

@janbartel
Copy link
Contributor

Jetty-10

The demo-spec module has a [depends] clause for demo-jndi, but it should not, because these two webapps are entirely independent.
@janbartel janbartel added this to the 10.0.x milestone Sep 28, 2020
joakime added a commit that referenced this issue Sep 28, 2020
@joakime
Issue #5360 - removing dependency to demo-jndi from demo-spec
da40eb4 
Signed-off-by: Joakim Erdfelt <[email protected]>
@joakime joakime linked a pull request Sep 28, 2020 that will close this issue
Issue #5360 - removing dependency to demo-jndi from demo-spec #5364
Merged
@joakime
Copy link
Contributor

joakime commented Sep 28, 2020

Opened PR #5364

joakime added a commit that referenced this issue Sep 28, 2020
@joakime
Issue #5360 - Adding demo-jndi to demo.mod
b02de4b 
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime added a commit that referenced this issue Sep 28, 2020
@joakime
Issue #5360 - removing dependency to demo-jndi from demo-spec (#5364)
a9f728f 
* Issue #5360 - removing dependency to demo-jndi from demo-spec

+ Adding demo-jndi dep to demo.mod instead.

Signed-off-by: Joakim Erdfelt <[email protected]>
janbartel added a commit that referenced this issue Sep 29, 2020
@janbartel
Issue #5360 Ensure @WebListeners have origin attr in quickstart-web.xml
dc7b693 
Signed-off-by: Jan Bartel <[email protected]>
gregw pushed a commit that referenced this issue Sep 30, 2020
@janbartel
Issue #5360 Ensure @WebListeners have origin attr in quickstart-web.x…
a2260dd 
…ml (#5371)

Signed-off-by: Jan Bartel <[email protected]>
janbartel added a commit that referenced this issue Oct 6, 2020
@janbartel
Issue #5360 Add more origin info to quickstart-web.xml elements
87ee2dd 
Signed-off-by: Jan Bartel <[email protected]>
janbartel added a commit that referenced this issue Oct 14, 2020
@janbartel
Add more origin info to quickstart-web.xml elements (#5400)
5e60837 
* Issue #5360 Add more origin info to quickstart-web.xml elements

Signed-off-by: Jan Bartel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
None yet
Projects
None yet
Milestone
10.0.x
Development

Successfully merging a pull request may close this issue.

Issue #5360 - removing dependency to demo-jndi from demo-spec jetty/jetty.project
2 participants
@joakime @janbartel