Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueuedThreadPool setDetailedDump gives less detail #5201

Closed
lachlan-roberts opened this issue Aug 26, 2020 · 1 comment
Closed

QueuedThreadPool setDetailedDump gives less detail #5201

lachlan-roberts opened this issue Aug 26, 2020 · 1 comment
Assignees

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version
9.4.x

Description
It looks like QueuedThreadPool.setDetailedDump(true) seems to give less detail than when detailedDump is false. I think this option shouldn't omit details in the detailed dump that we already had in the standard dump.

detailed dump off:

+= QueuedThreadPool[qtp1698097425]@6536e911{STARTED,8<=8<=200,i=8,r=4,q=0}[ReservedThreadExecutor@37574691{s=0/4,p=0}] - STARTED
|  += ReservedThreadExecutor@37574691{s=0/4,p=0} - STARTED
|  +> threads size=8
|     +> 12 qtp1698097425-12 IDLE TIMED_WAITING @ [email protected]/jdk.internal.misc.Unsafe.park(Native Method)
|     +> 13 qtp1698097425-13 IDLE TIMED_WAITING @ [email protected]/jdk.internal.misc.Unsafe.park(Native Method)
|     +> 15 qtp1698097425-15 IDLE TIMED_WAITING @ [email protected]/jdk.internal.misc.Unsafe.park(Native Method)
|     +> 17 qtp1698097425-17 IDLE TIMED_WAITING @ [email protected]/jdk.internal.misc.Unsafe.park(Native Method)
|     +> 19 qtp1698097425-19 IDLE TIMED_WAITING @ [email protected]/jdk.internal.misc.Unsafe.park(Native Method)
|     +> 16 qtp1698097425-16 IDLE TIMED_WAITING @ [email protected]/jdk.internal.misc.Unsafe.park(Native Method)
|     +> 18 qtp1698097425-18 IDLE TIMED_WAITING @ [email protected]/jdk.internal.misc.Unsafe.park(Native Method)
|     +> 14 qtp1698097425-14 IDLE TIMED_WAITING @ [email protected]/jdk.internal.misc.Unsafe.park(Native Method)

detailed dump on:

+= QueuedThreadPool[qtp1795799895]@6b09bb57{STARTED,8<=8<=200,i=8,r=4,q=0}[ReservedThreadExecutor@37574691{s=0/4,p=0}] - STARTED
|  += ReservedThreadExecutor@37574691{s=0/4,p=0} - STARTED
|  +> threads size=8
|  |  +> 12 qtp1795799895-12 IDLE  TIMED_WAITING 5
|  |  +> 13 qtp1795799895-13 IDLE  TIMED_WAITING 5
|  |  +> 14 qtp1795799895-14 IDLE  TIMED_WAITING 5
|  |  +> 16 qtp1795799895-16 IDLE  TIMED_WAITING 5
|  |  +> 18 qtp1795799895-18 IDLE  TIMED_WAITING 5
|  |  +> 17 qtp1795799895-17 IDLE  TIMED_WAITING 5
|  |  +> 19 qtp1795799895-19 IDLE  TIMED_WAITING 5
|  |  +> 15 qtp1795799895-15 IDLE  TIMED_WAITING 5
|  +> jobs size=0
@sbordet
Copy link
Contributor

sbordet commented Aug 26, 2020

@lachlan-roberts I think more details are dumped for threads that are not "known" ("known" threads are idle in the pool, or in select(), etc. IIRC the whole stack trace is printed.

So perhaps it's worth normalizing the "known" threads output although it does not seem to add much - I won't object if
[email protected]/jdk.internal.misc.Unsafe.park(Native Method) is removed.

@lachlan-roberts lachlan-roberts self-assigned this Sep 2, 2020
lachlan-roberts added a commit that referenced this issue Sep 2, 2020
lachlan-roberts added a commit that referenced this issue Sep 3, 2020
lachlan-roberts added a commit that referenced this issue Sep 4, 2020
lachlan-roberts added a commit that referenced this issue Sep 4, 2020
…olDump

Issue #5201 - simplify the QueuedThreadPool dump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants