Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GzipHandler #5198

Closed
gregw opened this issue Aug 25, 2020 · 0 comments · Fixed by #5248
Closed

Update GzipHandler #5198

gregw opened this issue Aug 25, 2020 · 0 comments · Fixed by #5248
Assignees
@lachlan-roberts
Milestone
10.0.x

Comments

@gregw
Copy link
Contributor

gregw commented Aug 25, 2020

GzipHandler can user the ByteBuffer API in Jetty-10.
There are also several other open GzipHandler issues that might be addressed in an update: #4988, #4317, #2553, #1761
@gregw gregw added this to the 10.0.x milestone Aug 25, 2020
lachlan-roberts added a commit that referenced this issue Sep 8, 2020
@lachlan-roberts
Issue #5198 - GzipHandler should use InflaterPool as well as Deflater…
3bdd82e 
…Pool

Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue Sep 8, 2020
@lachlan-roberts
Issue #5198 - use ByteBuffer API for inflater/deflaters for GzipHandler
7a04b3e 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue Sep 9, 2020
@lachlan-roberts
Issue #5198 - fix usage of inflater/deflater ByteBuffer API
67e5ad3 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue Sep 9, 2020
@lachlan-roberts
Issue #5198 - fix usage of inflater/deflater ByteBuffer API
4e6827c 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue Sep 9, 2020
@lachlan-roberts
Issue #5198 - revert usage of deflater ByteBuffer API for GzipHandler
2f23c59 
The CRC32 checksum may need to convert the ByteBuffer to an array anyway so
we are better off not setting the deflater input with ByteBuffer directly.

Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts lachlan-roberts mentioned this issue Sep 9, 2020
Merged
@joakime joakime mentioned this issue Sep 17, 2020
Closed
lachlan-roberts added a commit that referenced this issue Sep 21, 2020
@lachlan-roberts
Merge pull request #5248 from eclipse/jetty-10.0.x-5198-UpdateGzipHan…
df085a6 
…dler

Issue #5198 - update gzip handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
None yet
Projects
None yet
Milestone
10.0.x
Development

Successfully merging a pull request may close this issue.

Issue #5198 - update gzip handler jetty/jetty.project
2 participants
@gregw @lachlan-roberts