Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy sets protocol version to 2.0 instead of 1.1 when accessed from H2 client #5103

Closed
travisspencer opened this issue Jul 31, 2020 · 0 comments · Fixed by #5225
Closed

Proxy sets protocol version to 2.0 instead of 1.1 when accessed from H2 client #5103

travisspencer opened this issue Jul 31, 2020 · 0 comments · Fixed by #5225
Assignees
@sbordet

Comments

@travisspencer
Copy link
Contributor

Jetty version

9.4.30.v20200611

Java version

1.8.0_261

OS type/version

Mac

Description

When AsyncProxyServlet is exposed via H2, the protocol version in the request line sent downstream to the origin server is copied from the caller's request and set to H2. The actual message, however, is encoded as 1.1. This should be fixed by setting the version explicitly to 1.1.

Refer to the user mailing list thread for background discussion. https://www.eclipse.org//lists/jetty-users/msg09541.html
@sbordet sbordet self-assigned this Sep 2, 2020
@sbordet sbordet linked a pull request Sep 2, 2020 that will close this issue
Fixes #5103 - Proxy sets protocol version to 2.0 instead of 1.1 when … #5225
Merged
sbordet added a commit that referenced this issue Sep 2, 2020
@sbordet
Merge pull request #5225 from eclipse/jetty-9.4.x-5103_proxy_wrong_ht…
e940e5c 
…tp_version

Fixes #5103 - Proxy sets protocol version to 2.0 instead of 1.1 when …
@sbordet sbordet closed this as completed in 1e90d13 Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #5103 - Proxy sets protocol version to 2.0 instead of 1.1 when … jetty/jetty.project
2 participants
@sbordet @travisspencer