Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org.eclipse.jetty.util.Attributes.getAttribute() should specify return type if no match is found #11507

Closed
cowwoc opened this issue Mar 12, 2024 · 2 comments · Fixed by #11843
Closed

org.eclipse.jetty.util.Attributes.getAttribute() should specify return type if no match is found #11507

cowwoc opened this issue Mar 12, 2024 · 2 comments · Fixed by #11843
Labels
Bug For general bugs on Jetty side

Comments

@cowwoc
Copy link
Contributor

cowwoc commented Mar 12, 2024

Jetty version(s)
12.0.6

Jetty Environment
core

Description
I believe that org.eclipse.jetty.util.Attributes.getAttribute() returns null if no match is found, but the Javadoc does not specify either way. In contrast, the servlet API makes this explicit.
@cowwoc cowwoc added the Bug For general bugs on Jetty side label Mar 12, 2024
gregw added a commit that referenced this issue May 26, 2024
@gregw
Fix #11507 getAttribute javadoc
a29c562 
Fix #11507 getAttribute javadoc.
As some stage we should consider @nullable or @NotNull annotations...
@gregw gregw mentioned this issue May 26, 2024
Merged
@gregw gregw moved this to 👀 In review in Jetty 12.0.10 (FROZEN) May 27, 2024
@gregw
Copy link
Contributor

gregw commented May 27, 2024

@cowwoc Can you give a quick review of #11843. Is that what you intended?

@cowwoc
Copy link
Contributor Author

cowwoc commented May 27, 2024

@gregw yes. This is perfect. Thank you!

gregw added a commit that referenced this issue May 27, 2024
@gregw
Fix #11507 getAttribute javadoc (#11843)
7e36f3c 
Fix #11507 getAttribute javadoc.
As some stage we should consider @nullable or @NotNull annotations...
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Jetty 12.0.10 (FROZEN) May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 12.0.10 (FROZEN)
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #11507 getAttribute javadoc jetty/jetty.project
2 participants
@gregw @cowwoc