Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce MultiPartCompliance.LEGACY (not as default) too allow for parsing of non-compliant multipart/form-data #11387

Closed
joakime opened this issue Feb 7, 2024 · 0 comments · Fixed by #11388
Closed

Reintroduce MultiPartCompliance.LEGACY (not as default) too allow for parsing of non-compliant multipart/form-data #11387

joakime opened this issue Feb 7, 2024 · 0 comments · Fixed by #11388
Assignees
@joakime
Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement

Comments

@joakime
Copy link
Contributor

joakime commented Feb 7, 2024

Jetty version(s)
12.0.6

Enhancement Description
Reintroduce the MultiPartCompliance.LEGACY mode to allow the parser to be configured for a more lenient parsing mode.
@joakime joakime self-assigned this Feb 7, 2024
@joakime joakime added the Sponsored This issue affects a user with a commercial support agreement label Feb 7, 2024
joakime added a commit that referenced this issue Feb 7, 2024
@joakime
Issue #11387: Reintroduce MultiPartCompliance.LEGACY in ee9/ee8
e125ada
@joakime joakime linked a pull request Feb 7, 2024 that will close this issue
Issue #11387: Reintroduce MultiPartCompliance.LEGACY in ee9/ee8 #11388
Merged
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.7 - FROZEN Feb 7, 2024
joakime added a commit that referenced this issue Feb 27, 2024
@joakime @sbordet
Issue #11387: Reintroduce MultiPartCompliance.LEGACY in ee9/ee8 (#11388)
98ceb73 
* Issue #11387: Reintroduce MultiPartCompliance.LEGACY in ee9/ee8
* Correcting javadoc
* Updating MultiPartCaptureTest to ...
  * Test with MultiPartFormData.Parser and MultiPart.Parser
 * Enable all test cases
    * base64 behaviors modified to not auto-decode base64 content
    * forms submitted without `_charset_` part (some using a different
       charset than UTF-8, like `Shift_JIS`)
* Fixing checkstyle warning
* Re-enable Part-ContainsContents expectations
* Rename MultiPartCompliance.NO_CRLF_AFTER_PREAMBLE to WHITESPACE_BEFORE_BOUNDARY to fit spec better
* Make ee9/ee8 legacy parser use legacy tokenization
* Testing ee9/ee8 legacy parser base64 auto-decoding behaviors
* Cleanup jetty-test-multipart class naming
* Adding ee10 tests against raw multipart examples
* Adding shorter whitespace multipart test
* Adding jetty-core version of failing ee10 tests
* Fixed missed notification for CR content in case of 1 chunk ending with CR and the next chunk ending with LF.
* Removed internal unused class MultiPartParser.
* Adding MultiPartCompliance.Violation events
  + in MultiPart.Parser
  + in MultiPartFormData.Parser
* lenient mode behavior
* new name fits violation better
+ adding violation to MultiPart.Parser.parseHeaderStart
* some simple cleanup of new ee9 code

Signed-off-by: Simone Bordet <[email protected]>
Co-authored-by: Simone Bordet <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.7 - FROZEN Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 12.0.7 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #11387: Reintroduce MultiPartCompliance.LEGACY in ee9/ee8 jetty/jetty.project
1 participant
@joakime