Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AllowedResourceAliasChecker and SymlinkAllowedResourceAliasChecker do not work with a CombinedResource #11271

Closed
joakime opened this issue Jan 12, 2024 · 0 comments · Fixed by #11279
Closed

AllowedResourceAliasChecker and SymlinkAllowedResourceAliasChecker do not work with a CombinedResource #11271

joakime opened this issue Jan 12, 2024 · 0 comments · Fixed by #11279
Assignees
@lachlan-roberts
Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Milestone
12.0.x

Comments

@joakime
Copy link
Contributor

joakime commented Jan 12, 2024

Jetty version(s)
12

Jetty Environment
All

Java version/vendor (use: java -version)
Any

OS type/version
Any

Description
Both the AllowedResourceAliasChecker and SymlinkAllowedResourceAliasChecker implementations will fail if the base resource is a CombinedResource due to the _base logic between the two classes.

Those default implementations should work with a CombinedResource.
@joakime joakime added the Bug For general bugs on Jetty side label Jan 12, 2024
@joakime joakime added this to the 12.0.x milestone Jan 12, 2024
@joakime joakime added the Sponsored This issue affects a user with a commercial support agreement label Jan 12, 2024
@lachlan-roberts lachlan-roberts mentioned this issue Jan 16, 2024
Merged
@joakime joakime linked a pull request Jan 16, 2024 that will close this issue
Issue #11271 - fix use of AliasCheckers with CombinedResource #11279
Merged
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.6 FROZEN Jan 16, 2024
lachlan-roberts added a commit that referenced this issue Feb 21, 2024
@lachlan-roberts
Merge pull request #11279 from jetty/jetty-12.0.x-11271-AliasCheckCom…
33e00dc 
…binedResource

Issue #11271 - fix use of AliasCheckers with CombinedResource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 12.0.7 - FROZEN
Status: ✅ Done
Milestone
12.0.x
Development

Successfully merging a pull request may close this issue.

Issue #11271 - fix use of AliasCheckers with CombinedResource jetty/jetty.project
2 participants
@joakime @lachlan-roberts