Issue #4904 - WebsocketClient creates more connections than needed.

Fixed MultiplexConnectionPool.acquire() to use the new boolean parameter to decide whether or not create a new connection. This fixes ConnectionPoolTest instability. Signed-off-by: Simone Bordet <[email protected]>
jetty · Jul 9, 2020 · 6844c93 · 6844c93
1 parent 7bcbc21
commit 6844c93
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/jetty-client/src/main/java/org/eclipse/jetty/client/MultiplexConnectionPool.java b/jetty-client/src/main/java/org/eclipse/jetty/client/MultiplexConnectionPool.java
@@ -57,10 +57,10 @@ public MultiplexConnectionPool(HttpDestination destination, int maxConnections,
     }
 
     @Override
-    public Connection acquire()
+    protected Connection acquire(boolean create)
     {
         Connection connection = activate();
-        if (connection == null)
+        if (connection == null && create)
         {
             int queuedRequests = getHttpDestination().getQueuedRequestCount();
             int maxMultiplex = getMaxMultiplex();