Issue #4443 - Track backport of ALPN APIs to Java 8.

Improved logging after review. Signed-off-by: Simone Bordet <[email protected]>
jetty · Mar 18, 2020 · 1be2f47 · 1be2f47
1 parent 6df47dd
commit 1be2f47
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/...ent/src/main/java/org/eclipse/jetty/alpn/openjdk8/client/OpenJDK8ClientALPNProcessor.java b/...ent/src/main/java/org/eclipse/jetty/alpn/openjdk8/client/OpenJDK8ClientALPNProcessor.java
@@ -55,10 +55,13 @@ public void init()
             // Use reflection so we can build with a JDK version less than 8u252.
             alpnProtocols = SSLParameters.class.getMethod("setApplicationProtocols", String[].class);
             alpnProtocol = SSLEngine.class.getMethod("getApplicationProtocol");
+            if (LOG.isDebugEnabled())
+                LOG.debug("Using OpenJDK ALPN APIs instead of Jetty ALPN APIs");
             return;
         }
-        catch (NoSuchMethodException ignored)
+        catch (NoSuchMethodException x)
         {
+            LOG.ignore(x);
         }
 
         // Backported ALPN APIs not available.

diff --git a/...ver/src/main/java/org/eclipse/jetty/alpn/openjdk8/server/OpenJDK8ServerALPNProcessor.java b/...ver/src/main/java/org/eclipse/jetty/alpn/openjdk8/server/OpenJDK8ServerALPNProcessor.java
@@ -52,10 +52,13 @@ public void init()
             // JDK 8u252 has the JDK 9 ALPN API backported.
             // Use reflection so we can build with a JDK version less than 8u252.
             alpnSelector = SSLEngine.class.getMethod("setHandshakeApplicationProtocolSelector", BiFunction.class);
+            if (LOG.isDebugEnabled())
+                LOG.debug("Using OpenJDK ALPN APIs instead of Jetty ALPN APIs");
             return;
         }
-        catch (NoSuchMethodException ignored)
+        catch (NoSuchMethodException x)
         {
+            LOG.ignore(x);
         }
 
         // Backported ALPN APIs not available.