Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http2-client to list of topics #7

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Add http2-client to list of topics #7

merged 1 commit into from
Oct 19, 2023

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Oct 19, 2023

Example for Jetty team on what a in-place edit to PR looks like

Example for Jetty team on what a in-place edit to PR looks like

Signed-off-by: Joakim Erdfelt <[email protected]>
@joakime joakime requested review from a team as code owners October 19, 2023 17:06
@github-actions
Copy link

Diff for 1d0b788:
Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization jetty[id=jetty]

  
!   repository[name="jetty.project"] {
!     topics                                                   = "['eclipse', 'embedded', 'fcgi', 'http', 'http-client', 'http-server', 'http2', 'http2-push', 'http3', 'https', 'jakartaee', 'java', 'jetty', 'jsp', 'osgi', 'servlet', 'ssl', 'tls', 'unix-socket', 'websockets']" -> "['eclipse', 'embedded', 'fcgi', 'http', 'http-client', 'http-server', 'http2', 'http2-client', 'http2-push', 'http3', 'https', 'jakartaee', 'java', 'jetty', 'jsp', 'osgi', 'servlet', 'ssl', 'tls', 'unix-socket', 'websockets']"
!   }
  
  Plan: 0 to add, 1 to change, 0 to delete.
Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Organization jetty[id=jetty]

@netomi netomi merged commit 8d1220a into jetty:main Oct 19, 2023
2 checks passed
@netomi
Copy link
Contributor

netomi commented Oct 19, 2023

A repository cannot have more than 20 topics.

need to add a validation for that.

@netomi
Copy link
Contributor

netomi commented Oct 19, 2023

going to revert that PR.

@netomi
Copy link
Contributor

netomi commented Oct 19, 2023

Created https://gitlab.eclipse.org/eclipsefdn/security/otterdog/-/issues/129 to improve the validation wrt topics.

@joakime joakime deleted the patch-1 branch October 19, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants