Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile session location #1130

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Conversation

paustint
Copy link
Contributor

@paustint paustint commented Jan 1, 2025

For user profiles where active sessions are shown, our local location service was not handled correctly where the shape of the data had a wrapper object that was not included from ip-api

Added graceful shutdown handling for jetstream core api server

For user profiles where active sessions are shown, our local location service was not handled correctly where the shape of the data had a wrapper object that was not included from ip-api

Added graceful shutdown handling for jetstream core api server
@paustint paustint requested a review from Copilot January 1, 2025 21:05

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • apps/jetstream/src/app/components/profile/2fa/Profile2fa.tsx: Evaluated as low risk
Comments suppressed due to low confidence (1)

apps/jetstream/src/app/components/profile/session/ProfileSessionItem.tsx:101

  • [nitpick] The display of the estimated location is inconsistent. Consider using the same format as when latitude and longitude are present.
return <span>(Est. location: {estimatedLocation})</span>;
@paustint paustint merged commit 5916b6c into main Jan 1, 2025
6 checks passed
@paustint paustint deleted the bug/fix-profile-session-location branch January 1, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant