Ensure captcha resets on login attempt #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Captcha reset was not working properly after any failed login/reset attempt - there was an issue with the ref being passed to useImperativeHandle Added custom messages to auth errors so the authentication login history has more context on where the errors are coming from resolves #1101
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
apps/landing/components/auth/Captcha.tsx:17
- [nitpick] The function name 'onStateChange' is ambiguous. It should be renamed to 'onCaptchaStateChange' for better clarity.
onStateChange: (isFinished: boolean) => void;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Captcha reset was not working properly after any failed login/reset attempt - there was an issue with the ref being passed to useImperativeHandle
Added custom messages to auth errors so the authentication login history has more context on where the errors are coming from
resolves #1101