Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of records in file and number of records uploaded are different #171

Closed
paustint opened this issue Mar 1, 2023 · 1 comment · Fixed by #182
Closed

Number of records in file and number of records uploaded are different #171

paustint opened this issue Mar 1, 2023 · 1 comment · Fixed by #182
Labels
bug Something isn't working

Comments

@paustint
Copy link
Contributor

paustint commented Mar 1, 2023

Describe the bug
This was uploading custom metadata, so it is possible there are duplicates in the file (that is one possible explanation)

Need to dig in and see if this can be reproduced.

image
@paustint paustint added the bug Something isn't working label Mar 1, 2023
@paustint
Copy link
Contributor Author

paustint commented Mar 2, 2023

I confirmed that custom metadata with duplicate records (based on DeveloperName) will cause this behavior.

We should warn the user that they have duplicates but allow them to proceed. Ideally we would even show them the duplicates in a table.

💡 we could also do this for any load

  • Update/Delete: See if duplicate Ids exist
  • Upsert: See if duplicate external Ids exist
  • Metadata: See if duplicate DeveloperName records exist

paustint added a commit that referenced this issue Mar 3, 2023
@paustint
Check load file for duplicates
697029f 
Check if load file has duplicate records

Show warning if duplicates exist and allow user to view duplicates in modal

resolves #171
@paustint paustint mentioned this issue Mar 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check load file for duplicates jetstreamapp/jetstream
1 participant
@paustint