Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent light/dark theme. It'd be good to have consistent light and dark mode. #1109

Open
praulkar opened this issue Dec 10, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@praulkar
Copy link

Currently, the app weirdly has a inconsistent mix of dark background and light tiles, or dark and light page background in same screen which feels very incoherent. It'd be good to have a uniform Light or Dark theme option which is consistent across application. Examples below.

SCR-20241210-jgqx SCR-20241210-jgop SCR-20241210-jgnc SCR-20241210-jgja
@praulkar praulkar added the enhancement New feature or request label Dec 10, 2024
@paustint
Copy link
Contributor

@praulkar - I agree that we are inconsistent. We would love to offer full dark mode support, but as we are using the Salesforce lightning design system, it would be significant effort since it is not supported out of the box by Salesforce - so this is very low priority.

I understand that the code editors do add inconsistency, but the light mode editors in those areas didn't feel great, even though it was consistent. I am going to leave those as-is for now but will consider offering a preference on the color for editors.

I will fix the home page background color so that the contrast there will be less jarring.

Going to leave this issue open for now as a low priority item.

paustint added a commit that referenced this issue Dec 20, 2024
Matched salesforce brand color of light blue - this applies mostly to the app home page, but also applies to the background between components

work towards #1109
@praulkar
Copy link
Author

The landing page looks great! I understand how complex it would be. Giving an option for the code editor would be amazing. Appreciate the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants