Require strict null checks

Added strict null checks for all libraries

.nxignore

@@ -0,0 +1 @@
+apps/electron/Readme.md

apps/jetstream/src/app/app-state.ts

@@ -13,7 +13,7 @@ import {
 } from '@jetstream/types';
 import localforage from 'localforage';
 import isString from 'lodash/isString';
-import { atom, selector, useRecoilValue, useSetRecoilState } from 'recoil';
+import { atom, selector, selectorFamily, useRecoilValue, useSetRecoilState } from 'recoil';
 
 export const STORAGE_KEYS = {
   SELECTED_ORG_STORAGE_KEY: `SELECTED_ORG`,
@@ -135,7 +135,7 @@ export const selectedOrgIdState = atom<string>({
   default: getSelectedOrgFromStorage(),
 });
 
-export const selectedOrgState = selector({
+export const selectedOrgStateWithoutPlaceholder = selector({
   key: 'selectedOrgState',
   get: ({ get }) => {
     const salesforceOrgs = get(salesforceOrgsState);
@@ -147,6 +147,36 @@ export const selectedOrgState = selector({
   },
 });
 
+/**
+ * If no org is selected, this returns a placeholder
+ * it is expected that any component with an org required
+ * will be wrapped in an <OrgSelectionRequired> component to guard against this
+ */
+export const selectedOrgState = selector({
+  key: 'selectedOrgState',
+  get: ({ get }) => {
+    const PLACEHOLDER: SalesforceOrgUi = {
+      uniqueId: '',
+      label: '',
+      filterText: '',
+      accessToken: '',
+      instanceUrl: '',
+      loginUrl: '',
+      userId: '',
+      email: '',
+      organizationId: '',
+      username: '',
+      displayName: '',
+    };
+    const salesforceOrgs = get(salesforceOrgsState);
+    const selectedOrgId = get(selectedOrgIdState);
+    if (isString(selectedOrgId) && Array.isArray(salesforceOrgs)) {
+      return salesforceOrgs.find((org) => org.uniqueId === selectedOrgId) || PLACEHOLDER;
+    }
+    return PLACEHOLDER;
+  },
+});
+
 export const salesforceOrgsOmitSelectedState = selector({
   key: 'salesforceOrgsOmitSelectedState',
   get: ({ get }) => {

apps/jetstream/src/app/components/anonymous-apex/AnonymousApex.tsx

@@ -48,7 +48,7 @@ export interface AnonymousApexProps {}
 
 export const AnonymousApex: FunctionComponent<AnonymousApexProps> = () => {
   useTitle(TITLES.ANON_APEX);
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   const apexRef = useRef<editor.IStandaloneCodeEditor>(null);
   const logRef = useRef<editor.IStandaloneCodeEditor>(null);
   const { trackEvent } = useAmplitude();

apps/jetstream/src/app/components/anonymous-apex/useApexCompletions.ts

@@ -15,7 +15,7 @@
 //  * @returns
 //  */
 // export function useApexCompletions(org: SalesforceOrgUi) {
-//   const isMounted = useRef(null);
+//   const isMounted = useRef(true);
 //   const [_completions, setCompletions] = useState<MapOf<ApexCompletion>>(null);
 //   const [loading, setLoading] = useState(false);
 

apps/jetstream/src/app/components/automation-control/AutomationControlEditor.tsx

@@ -66,7 +66,7 @@ export const AutomationControlEditor: FunctionComponent<AutomationControlEditorP
 
   const [dirtyRows, setDirtyRows] = useState<TableRowItem[]>([]);
   const [saveModalOpen, setSaveModalOpen] = useState(false);
-  const [quickFilterText, setQuickFilterText] = useState<string>(null);
+  const [quickFilterText, setQuickFilterText] = useState<string | null>(null);
 
   const [exportDataModalOpen, setExportDataModalOpen] = useState<boolean>(false);
   const [exportDataModalData, setExportDataModalData] = useState<any[]>([]);

apps/jetstream/src/app/components/automation-control/useAutomationControlData.ts

@@ -557,7 +557,7 @@ export function useAutomationControlData({
   selectedSObjects: string[];
   selectedAutomationTypes: AutomationMetadataType[];
 }) {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   const { trackEvent } = useAmplitude();
   const rollbar = useRollbar();
 

apps/jetstream/src/app/components/core/AppLoading.tsx

@@ -4,7 +4,7 @@ import { FunctionComponent, useEffect, useRef, useState } from 'react';
 const delayMs = 300;
 
 export const AppLoading: FunctionComponent = () => {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   const [isActive, setIsActive] = useState(false);
 
   useEffect(() => {

apps/jetstream/src/app/components/core/AppStateResetOnOrgChange.tsx

@@ -14,7 +14,7 @@ export interface AppStateResetOnOrgChangeProps {}
 
 export const AppStateResetOnOrgChange: FunctionComponent<AppStateResetOnOrgChangeProps> = () => {
   const selectedOrg = useRecoilValue<SalesforceOrgUi>(fromAppState.selectedOrgState);
-  const [priorSelectedOrg, setPriorSelectedOrg] = useState<string>(null);
+  const [priorSelectedOrg, setPriorSelectedOrg] = useState<string | null>(null);
 
   const resetFns: Resetter[] = [
     // QUERY

apps/jetstream/src/app/components/core/HeaderDonatePopover.tsx

@@ -5,7 +5,7 @@ import { FunctionComponent, useEffect, useRef } from 'react';
 export interface HeaderDonatePopoverProps {}
 
 export const HeaderDonatePopover: FunctionComponent<HeaderDonatePopoverProps> = () => {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   const popoverRef = useRef<PopoverRef>(null);
 
   useEffect(() => {

apps/jetstream/src/app/components/core/HeaderHelpPopover.tsx

@@ -5,7 +5,7 @@ import { FunctionComponent, useEffect, useRef } from 'react';
 export interface HeaderHelpPopoverProps {}
 
 export const HeaderHelpPopover: FunctionComponent<HeaderHelpPopoverProps> = () => {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   const popoverRef = useRef<PopoverRef>(null);
 
   useEffect(() => {

apps/jetstream/src/app/components/core/ViewEditCloneRecord.tsx

@@ -74,7 +74,7 @@ export const ViewEditCloneRecord: FunctionComponent<ViewEditCloneRecordProps> =
   onFetch,
   onFetchError,
 }) => {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   const [{ google_apiKey, google_appId, google_clientId }] = useRecoilState(applicationCookieState);
   const [sobjectFields, setSobjectFields] = useState<Field[]>();
   const [picklistValues, setPicklistValues] = useState<PicklistFieldValues>();

apps/jetstream/src/app/components/core/record-lookup/RecordLookupPopover.tsx

@@ -27,7 +27,7 @@ export const RecordLookupPopover: FunctionComponent = () => {
   const selectedOrg = useRecoilValue<SalesforceOrgUi>(selectedOrgState);
 
   const [loading, setLoading] = useState<boolean>();
-  const [errorMessage, setErrorMessage] = useState<string>(null);
+  const [errorMessage, setErrorMessage] = useState<string | null>(null);
 
   const [recentRecords, setRecentRecords] = useState<RecentRecord[]>();
   const [modalOpen, setModalOpen] = useState<boolean>();

apps/jetstream/src/app/components/create-object-and-fields/CreateNewGlobalPicklistModal.tsx

@@ -59,7 +59,7 @@ export const CreateNewGlobalPicklistModal: FunctionComponent<CreateNewGlobalPick
   const rollbar = useRollbar();
   const [{ defaultApiVersion }] = useRecoilState(applicationCookieState);
   const [isOpen, setIsOpen] = useState(false);
-  const [errorMessage, setErrorMessage] = useState<string>(null);
+  const [errorMessage, setErrorMessage] = useState<string | null>(null);
 
   const [picklistData, setPicklistData] = useState<PicklistData>({ ...defaultValues });
   const [isValid, setIsValid] = useState(false);

apps/jetstream/src/app/components/create-object-and-fields/CreateObjectAndFields.tsx

@@ -22,7 +22,7 @@ export const CreateObjectAndFields: FunctionComponent<CreateObjectAndFieldsProps
   const resetSObjectsState = useResetRecoilState(fromCreateFieldsState.sObjectsState);
   const resetSelectedSObjectsState = useResetRecoilState(fromCreateFieldsState.selectedSObjectsState);
   const resetFieldRowsState = useResetRecoilState(fromCreateFieldsState.fieldRowsState);
-  const [priorSelectedOrg, setPriorSelectedOrg] = useState<string>(null);
+  const [priorSelectedOrg, setPriorSelectedOrg] = useState<string | null>(null);
 
   const hasSelectionsMade = useRecoilValue(fromCreateFieldsState.hasSelectionsMade);
 

apps/jetstream/src/app/components/debug-log-viewer/DebugLogViewer.tsx

@@ -38,7 +38,7 @@ export interface DebugLogViewerProps {}
 
 export const DebugLogViewer: FunctionComponent<DebugLogViewerProps> = () => {
   useTitle(TITLES.DEBUG_LOGS);
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   const logCache = useRef<MapOf<string>>({});
   const logRef = useRef<editor.IStandaloneCodeEditor>(null);
   const [{ serverUrl }] = useRecoilState(applicationCookieState);

apps/jetstream/src/app/components/debug-log-viewer/DebugLogViewerTable.tsx

@@ -79,7 +79,7 @@ export interface DebugLogViewerTableProps {
 }
 
 export const DebugLogViewerTable: FunctionComponent<DebugLogViewerTableProps> = ({ logs, onRowSelection }) => {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
 
   useEffect(() => {
     isMounted.current = true;

apps/jetstream/src/app/components/debug-log-viewer/DebugLogViewerTrace.tsx

@@ -9,7 +9,7 @@ export interface DebugLogViewerTraceProps {
 }
 
 export const DebugLogViewerTrace: FunctionComponent<DebugLogViewerTraceProps> = ({ org }) => {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   const popoverRef = useRef<PopoverRef>(null);
   const { changeLogLevel, loading, errorMessage, activeDebugLevel, debugLevels } = useSetTraceFlag(org);
 

apps/jetstream/src/app/components/debug-log-viewer/PurgeLogsModal.tsx

@@ -15,7 +15,7 @@ export interface PurgeLogsModalProps {
 }
 
 export const PurgeLogsModal: FunctionComponent<PurgeLogsModalProps> = ({ selectedOrg, onModalClose }) => {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   const [status, setStatus] = useState<Status>('NOT_STARTED');
   const [whichUsers, setWhichUsers] = useState<WhichUsers>('ALL');
 

apps/jetstream/src/app/components/debug-log-viewer/useDebugLogs.tsx

@@ -11,15 +11,15 @@ const MAX_POLL_ATTEMPTS = 25;
 
 export function useDebugLogs(org: SalesforceOrgUi, { limit, pollInterval, userId }: UseDebugLogsOptions) {
   pollInterval = pollInterval || DEFAULT_POLL_INTERVAL;
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   /** Used so that if multiple requests come in at about the same time, we can ignore results from intermediate requests as they may not be valid */
   const currentFetchToken = useRef<number>(new Date().getTime());
   const numPollErrors = useRef<number>(0);
   const [loading, setLoading] = useState(false);
   const [errorMessage, setErrorMessage] = useState();
   const [logs, setLogs] = useState<ApexLog[]>([]);
   /** If provided, will only fetch the most resent logs */
-  const [asOfId, setAsOfId] = useState<string>(null);
+  const [asOfId, setAsOfId] = useState<string | null>(null);
   const [intervalDelay, setIntervalDelay] = useState<number | null>(null);
   const [lastChecked, setLastChecked] = useState<Date>();
 

apps/jetstream/src/app/components/deploy/DeployMetadata.tsx

@@ -25,7 +25,7 @@ export const DeployMetadata: FunctionComponent<DeployMetadataProps> = () => {
   const resetChangesetPackage = useResetRecoilState(fromDeployMetadataState.changesetPackage);
   const resetChangesetPackages = useResetRecoilState(fromDeployMetadataState.changesetPackages);
 
-  const [priorSelectedOrg, setPriorSelectedOrg] = useState<string>(null);
+  const [priorSelectedOrg, setPriorSelectedOrg] = useState<string | null>(null);
 
   // reset everything if the selected org changes
   useEffect(() => {

apps/jetstream/src/app/components/deploy/DeployMetadataDeploymentTable.tsx

@@ -26,7 +26,7 @@ export const DeployMetadataDeploymentTable: FunctionComponent<DeployMetadataDepl
 }) => {
   const [columns, setColumns] = useState<ColumnWithFilter<DeployMetadataTableRow>[]>([]);
   const [visibleRows, setVisibleRows] = useState<DeployMetadataTableRow[]>(rows);
-  const [globalFilter, setGlobalFilter] = useState<string>(null);
+  const [globalFilter, setGlobalFilter] = useState<string | null>(null);
   const [selectedRowIds, setSelectedRowIds] = useState(new Set<any>());
   const [expandedGroupIds, setExpandedGroupIds] = useState(new Set<any>());
 

apps/jetstream/src/app/components/deploy/deploy-metadata-history/DeployMetadataHistoryModal.tsx

@@ -43,7 +43,7 @@ export const DeployMetadataHistoryModal = ({ className }: DeployMetadataHistoryM
   });
   const [historyItems, setHistoryItems] = useState<SalesforceDeployHistoryItem[]>([]);
   const [isLoading, setIsLoading] = useState(false);
-  const [errorMessage, setError] = useState<string>(null);
+  const [errorMessage, setError] = useState<string | null>(null);
   const orgsById = useRecoilValue(fromAppState.salesforceOrgsById);
 
   useEffect(() => {

apps/jetstream/src/app/components/deploy/deploy-metadata-package/DeployMetadataPackageConfigModal.tsx

@@ -50,7 +50,7 @@ export const DeployMetadataPackageConfigModal: FunctionComponent<DeployMetadataP
   const [filename, setFileName] = useState<string>(initialFilename);
   const [fileContents, setFileContents] = useState<string[]>(initialFileContents);
   const [isConfigValid, setIsConfigValid] = useState(true);
-  const [zipFileError, setZipFileError] = useState<string>(null);
+  const [zipFileError, setZipFileError] = useState<string | null>(null);
   const [{ isSinglePackage, missingPackageXml }, setPackageDetection] = useState({
     isSinglePackage: initialIsSinglePackage ?? true,
     missingPackageXml: false,

apps/jetstream/src/app/components/deploy/selection-components/RadioButtonSelection.tsx

@@ -12,7 +12,7 @@ export interface RadioButtonSelectionProps {
   items: RadioButtonItem[];
   checkedValue: string;
   disabled?: boolean;
-  labelHelp?: string;
+  labelHelp?: string | null;
   onChange: (value: string) => void;
 }
 

apps/jetstream/src/app/components/deploy/utils/useAddItemsToChangeset.tsx

@@ -79,7 +79,7 @@ export function useAddItemsToChangeset(
     selectedMetadata,
   }: { changesetName: string; changesetDescription: string; selectedMetadata: MapOf<ListMetadataResult[]> }
 ) {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
 
   const [{ hasLoaded, loading, hasError, errorMessage, status, deployId, results }, dispatch] = useReducer(reducer, {
     hasLoaded: false,

apps/jetstream/src/app/components/deploy/utils/useChangesetList.tsx

@@ -4,7 +4,7 @@ import { ChangeSet, ListItem, SalesforceOrgUi } from '@jetstream/types';
 import { useCallback, useEffect, useReducer, useRef } from 'react';
 
 export function useChangesetList(selectedOrg: SalesforceOrgUi, initialPackages?: ListItem<string, ChangeSet>[]) {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
 
   const [{ hasLoaded, loading, data, hasError, errorMessage }, dispatch] = useReducer(useReducerFetchFn<ListItem<string, ChangeSet>[]>(), {
     hasLoaded: !!initialPackages,

apps/jetstream/src/app/components/deploy/utils/useDeployMetadataBetweenOrgs.tsx

@@ -77,7 +77,7 @@ export function useDeployMetadataBetweenOrgs(
   selectedMetadata: MapOf<ListMetadataResult[]>,
   deployOptions: DeployOptions
 ) {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
 
   const [{ hasLoaded, loading, hasError, errorMessage, status, deployId, results }, dispatch] = useReducer(reducer, {
     hasLoaded: false,

apps/jetstream/src/app/components/deploy/utils/useDeployMetadataPackage.tsx

@@ -75,7 +75,7 @@ function reducer(state: State, action: Action): State {
  * @param changesetName
  */
 export function useDeployMetadataPackage(destinationOrg: SalesforceOrgUi, deployOptions: DeployOptions, file: ArrayBuffer) {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
 
   const [{ hasLoaded, loading, hasError, errorMessage, status, deployId, results }, dispatch] = useReducer(reducer, {
     hasLoaded: false,

apps/jetstream/src/app/components/deploy/utils/useUsers.tsx

@@ -16,7 +16,7 @@ export function useUsers(
   sortCurrentUserFirst = true,
   loadOnInit = true
 ) {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   const [lastRefreshed, setLastRefreshed] = useState<string>(_lastRefreshed);
 
   const [{ hasLoaded, loading, data, hasError, errorMessage }, dispatch] = useReducer(

apps/jetstream/src/app/components/deploy/view-or-compare-metadata/ViewOrCompareMetadataModal.tsx

@@ -36,8 +36,8 @@ export const ViewOrCompareMetadataModal: FunctionComponent<ViewOrCompareMetadata
 
   const [activeFile, setActiveFile] = useState<TreeItems<FileItemMetadata | null>>(null);
   const [activeFileType, setActiveFileType] = useState<string>('xml');
-  const [activeSourceContent, setActiveSourceContent] = useState<string>(null);
-  const [activeTargetContent, setActiveTargetContent] = useState<string>(null);
+  const [activeSourceContent, setActiveSourceContent] = useState<string | null>(null);
+  const [activeTargetContent, setActiveTargetContent] = useState<string | null>(null);
   const [editorType, setEditorType] = useState<EditorType>('SOURCE');
   const [swapped, setSwapped] = useState(false);
 

apps/jetstream/src/app/components/deploy/view-or-compare-metadata/useViewOrCompareMetadata.tsx

@@ -145,7 +145,7 @@ function reducer(state: State, action: Action): State {
  * @param changesetName
  */
 export function useViewOrCompareMetadata({ selectedMetadata }: { selectedMetadata: MapOf<ListMetadataResult[]> }) {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
 
   const [
     {

apps/jetstream/src/app/components/formula-evaluator/FormulaEvaluator.tsx

@@ -65,16 +65,16 @@ export interface FormulaEvaluatorProps {}
 
 export const FormulaEvaluator: FunctionComponent<FormulaEvaluatorProps> = () => {
   useTitle(TITLES.FORMULA_EVALUATOR);
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   const editorRef = useRef<editor.IStandaloneCodeEditor>(null);
   const sobjectComboRef = useRef<SobjectComboboxRef>(null);
   const fieldsComboRef = useRef<SobjectFieldComboboxRef>(null);
   const { trackEvent } = useAmplitude();
   const selectedOrg = useRecoilValue<SalesforceOrgUi>(selectedOrgState);
   const [loading, setLoading] = useState(false);
   const [refreshLoading, setRefreshLoading] = useState(false);
-  const [fieldErrorMessage, setFieldErrorMessage] = useState<string>(null);
-  const [errorMessage, setErrorMessage] = useState<string>(null);
+  const [fieldErrorMessage, setFieldErrorMessage] = useState<string | null>(null);
+  const [errorMessage, setErrorMessage] = useState<string | null>(null);
   const [formulaValue, setFormulaValue] = useRecoilState(fromFormulaState.formulaValueState);
   const [selectedSObject, setSelectedSobject] = useRecoilState(fromFormulaState.selectedSObjectState);
   const [selectedField, setSelectedField] = useRecoilState(fromFormulaState.selectedFieldState);

apps/jetstream/src/app/components/load-records-multi-object/LoadRecordsMultiObject.tsx

@@ -41,7 +41,7 @@ export interface LoadRecordsMultiObjectProps {
 
 export const LoadRecordsMultiObject: FunctionComponent<LoadRecordsMultiObjectProps> = ({ featureFlags }) => {
   useTitle(TITLES.LOAD);
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   const { trackEvent } = useAmplitude();
   const selectedOrg = useRecoilValue<SalesforceOrgUi>(selectedOrgState);
   const orgType = useRecoilValue(selectedOrgType);

apps/jetstream/src/app/components/load-records-multi-object/useLoadFile.ts

@@ -131,7 +131,7 @@ export const useLoadFile = (org: SalesforceOrgUi, serverUrl: string, apiVersion:
     finished: false,
   });
 
-  const isMounted = useRef<boolean>(null);
+  const isMounted = useRef(true);
 
   useEffect(() => {
     isMounted.current = true;

apps/jetstream/src/app/components/load-records-multi-object/useProcessLoadFile.ts

@@ -42,7 +42,7 @@ export const useValidateLoadFile = (org: SalesforceOrgUi, apiVersion: string, op
     errors: [],
   });
 
-  const isMounted = useRef<boolean>(null);
+  const isMounted = useRef(true);
 
   useEffect(() => {
     isMounted.current = true;

apps/jetstream/src/app/components/load-records/LoadRecords.tsx

@@ -53,7 +53,7 @@ export interface LoadRecordsProps {
 
 export const LoadRecords: FunctionComponent<LoadRecordsProps> = ({ featureFlags }) => {
   useTitle(TITLES.LOAD);
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   const { trackEvent } = useAmplitude();
   const [{ defaultApiVersion, serverUrl, google_apiKey, google_appId, google_clientId }] = useRecoilState(applicationCookieState);
   const googleApiConfig = useMemo(

apps/jetstream/src/app/components/load-records/components/LoadRecordsAssignmentRules.tsx

@@ -27,7 +27,7 @@ export const LoadRecordsAssignmentRules: FunctionComponent<LoadRecordsAssignment
   selectedSObject,
   onAssignmentRule,
 }) => {
-  const isMounted = useRef(null);
+  const isMounted = useRef(true);
   const [picklistKey, setPickListKey] = useState(currKey);
   const [loading, setLoading] = useState(false);
   const [useAssignmentRules, setUseAssignmentRules] = useState(false);