Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waveform signal disappears on zoom with sample frequency is 10 kHz #284

Closed
mliberty1 opened this issue Jul 31, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@mliberty1
Copy link
Member

mliberty1 commented Jul 31, 2024

Joulescope model

JS220

UI version

1.1.10

What OS are you seeing the problem on?

Windows 11

What happened?

When I zoom all the way in, the signal disappears:
zoom_10khz

This does not happen at 1 MHz sampling frequency.

What was expected?

The Waveform widget should limit the zoom level and prevent the signal from disappearing.

How to reproduce?

  1. Configure sample frequency 10 kHz
  2. Pause sample streaming
  3. Use the scroll wheel to zoom in on the Waveform widget.
@mliberty1 mliberty1 added bug Something isn't working triage New issue that needs to be reviewed and prioritized labels Jul 31, 2024
@mliberty1 mliberty1 self-assigned this Jul 31, 2024
@mliberty1 mliberty1 removed the triage New issue that needs to be reviewed and prioritized label Jul 31, 2024
@mliberty1
Copy link
Member Author

on_action_x_zoom clamps the minimum to time64.MICROSECOND. While this is appropriate for the full 1 MHz sample rate, it is not correct for 10 kHz. The Waveform widget should adjust this minimum value based on the source signals. Neither self._signals nor self._signals_data give any indication of the underlying sample rate. Both the streaming sample source and the JLS Source must be modified to provide this information to the Waveform widget, which then needs to adjust the minimum x view appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

1 participant