Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jest-matcher-utils): Add pkg.types #9590

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

NiGhTTraX
Copy link
Contributor

Summary

IntelliJ based IDEs can't find the types without it.

Test plan

I made the change locally in the node_modules folder of a project and the IDE correctly picks up the types.

IntelliJ based IDEs can't find the types without it.
@codecov-io
Copy link

Codecov Report

Merging #9590 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9590   +/-   ##
=======================================
  Coverage   65.08%   65.08%           
=======================================
  Files         286      286           
  Lines       12144    12144           
  Branches     3008     3008           
=======================================
  Hits         7904     7904           
  Misses       3605     3605           
  Partials      635      635

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b83f75...6510ae6. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, missed that one. thanks!

@SimenB SimenB merged commit 9fbe3c5 into jestjs:master Feb 18, 2020
@NiGhTTraX NiGhTTraX deleted the matcher-utils-pkg-types branch February 18, 2020 10:29
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants