Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add GH Actions CI #9101

Merged
merged 12 commits into from
Feb 9, 2020
Merged

chore: add GH Actions CI #9101

merged 12 commits into from
Feb 9, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Oct 26, 2019

Summary

No idea if this'll work 🤷‍♀ I created this through GH's UI, so hopefully that means actions are enabled

Test plan

Green CI?

@SimenB
Copy link
Member Author

SimenB commented Oct 26, 2019 •
edited
Loading

worked surprisingly well 😅 missing mercurial on macos for some reason. also not sure about the windows failure.

nothing stopping us from adding the linux build though. @jeysal @thymikee thoughts?

@jeysal
Copy link
Contributor

jeysal commented Oct 27, 2019

Sure, I guess that's good for resilience if the other 27 CI systems go down 😅
Should shorten the job name IMO cause they're very verbose in the checks list, maybe "Node $v on $os"
List of preinstalled software - hg only for Ubuntu, not macOS - but Homebrew should work, so just install it maybe?

@SimenB SimenB mentioned this pull request Oct 31, 2019
Merged
@SimenB SimenB force-pushed the SimenB-patch-1 branch 2 times, most recently from f10c302 to c806758 Compare October 31, 2019 08:33
@SimenB
Copy link
Member Author

SimenB commented Oct 31, 2019

rebased this now that we should just skip hg

@codecov-io
Copy link

codecov-io commented Oct 31, 2019 •
edited
Loading

Codecov Report

Merging #9101 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9101   +/-   ##
=======================================
  Coverage   65.03%   65.03%           
=======================================
  Files         283      283           
  Lines       12113    12113           
  Branches     3000     3000           
=======================================
  Hits         7878     7878           
  Misses       3597     3597           
  Partials      638      638

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e47d43...4f34cff. Read the comment docs.

@natealcedo
Copy link

Hey, was looking at this. Might be a good idea to have caching. It's pretty simple with this https://github.com/actions/cache

@SimenB
Copy link
Member Author

SimenB commented Nov 20, 2019

It's drunk, tries to access another directory. no idea what's up

natealcedo
natealcedo reviewed Nov 20, 2019
View reviewed changes
.github/workflows/nodejs.yml
run: echo "::set-output name=dir::$(yarn cache dir)"
- uses: actions/cache@v1
with:
path: ${{ steps.yarn-cache.outputs.dir }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just cache node_modules instead of the whole outputs dir

Copy link

@natealcedo natealcedo Nov 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was playing around with cache and doing something like this works.

image

By the way, I just copy pasted that from this and replaced package-lock.json with yarn.lock actions/cache#94 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied from https://github.com/actions/cache/blob/master/examples.md#node---yarn

@SimenB SimenB force-pushed the SimenB-patch-1 branch 2 times, most recently from bd1bd47 to 9b820b9 Compare November 22, 2019 08:38
@drew-gross
Copy link

Codecov Report

Merging #9101 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9101   +/-   ##
=======================================
  Coverage   65.03%   65.03%           
=======================================
  Files         283      283           
  Lines       12113    12113           
  Branches     3000     3000           
=======================================
  Hits         7878     7878           
  Misses       3597     3597           
  Partials      638      638

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e47d43...73d9512. Read the comment docs.

@SimenB SimenB merged commit 4f62e93 into master Feb 9, 2020
@SimenB SimenB deleted the SimenB-patch-1 branch February 9, 2020 11:08
@SimenB SimenB mentioned this pull request Feb 9, 2020
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@natealcedo natealcedo natealcedo left review comments

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SimenB @jeysal @codecov-io @natealcedo @drew-gross @facebook-github-bot