chore: getMaxWorkers types #8434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8434 +/- ##
=======================================
Coverage 62.33% 62.33%
=======================================
Files 266 266
Lines 10737 10737
Branches 2615 2615
=======================================
Hits 6693 6693
Misses 3461 3461
Partials 583 583
Continue to review full report at Codecov.
|
8 tasks
SimenB
reviewed
May 7, 2019
Co-Authored-By: JoshRosenstein <[email protected]>
scotthovestadt
approved these changes
May 7, 2019
SimenB
approved these changes
May 7, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note: Creating separate isolated PR's for type adjustments that narrow the scope of effected files.
See #8436
getMaxWorkers - has capability to parse percentage strings , Therefore we should add string to its type, and remove unnecessary casting.
const maxWorkers = (argv.maxWorkers as unknown) as number | string;toconst maxWorkers = argv.maxWorkers. Or depreceateTest plan
No type errors thrown on build