Revert "Fix circular references in iterable equality" #8259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before re-merging the PR, we need to ensure the following test is added and passes:
I was able to isolate the cause of issues we are seeing to the following simple test case above. I see that the
iterableEquality
function itself is returningfalse
, but it's getting swallowed somewhere injasmineUtils
eq
and returningtrue
regardless.Hopefully can re-merge for the next release.
FYI @mattphillips
Test plan