Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade all dependencies but babel #8014

Merged
merged 26 commits into from
Mar 1, 2019
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 1, 2019

Summary

Spun off from #8011 since I wanna reduce the diff

Test plan

This should pass CI 😅 Node 6 in particular

@SimenB
Copy link
Member Author

SimenB commented Mar 1, 2019

Ok, it passed. Lemme try to upgrade some babel deps one by one, and merge when I have a minimal setup that works

@SimenB
Copy link
Member Author

SimenB commented Mar 1, 2019

Ok, I think I've got pretty strong evidence the issue is upgrading @babel/parser from 7.3.3 to 7.3.4. Version of @babel/core doesn't seem to affect it (kept it at 7.3.3 as well so it doesn't pull in 7.3.4). I'll merge this and open up an issue with Babel.

(all the other builds failed since I cancelled them - I was just interested in node 6)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants