fix: make sure generated name in config is stable across runs of Jest

e2e/__tests__/multiProjectRunner.test.js

@@ -425,6 +425,25 @@ test("doesn't bleed module file extensions resolution with multiple workers", ()
       };`,
   });
 
+  const {stdout: configOutput} = runJest(DIR, [
+    '--show-config',
+    '--projects',
+    'project1',
+    'project2',
+  ]);
+
+  const {configs} = JSON.parse(configOutput);
+
+  expect(configs).toHaveLength(2);
+
+  const [{name: name1}, {name: name2}] = configs;
+
+  expect(name1).toBeTruthy();
+  expect(name2).toBeTruthy();
+  expect(name1).toHaveLength(32);
+  expect(name2).toHaveLength(32);
+  expect(name1).not.toEqual(name2);
+
   const {stderr} = runJest(DIR, [
     '--no-watchman',
     '-w=2',

packages/jest-config/src/__tests__/normalize.test.js

@@ -63,68 +63,6 @@ it('picks a name based on the rootDir', () => {
   ).toBe(expected);
 });
 
-it('picks a name for projects based on the main rootDir', () => {
-  const rootDir = '/root/path/foo';
-  const firstExpected = crypto
-    .createHash('md5')
-    .update('/root/path/foo')
-    .digest('hex');
-  const secondExpected = crypto
-    .createHash('md5')
-    .update('/root/path/foo:1')
-    .digest('hex');
-
-  const options = normalize(
-    {
-      projects: [{}, {}],
-      rootDir,
-    },
-    {},
-  );
-
-  expect(options.options.projects[0].name).toBe(firstExpected);
-  expect(options.options.projects[1].name).toBe(secondExpected);
-});
-
-it('picks a name for projects based on the projects rootDir', () => {
-  const firstRootDir = '/root/path/foo';
-  const secondRootDir = '/root/path/bar';
-  const firstExpected = crypto
-    .createHash('md5')
-    .update('/root/path/foo')
-    .digest('hex');
-  const secondExpected = crypto
-    .createHash('md5')
-    .update('/root/path/foo:1')
-    .digest('hex');
-  const thirdExpected = crypto
-    .createHash('md5')
-    .update('/root/path/bar')
-    .digest('hex');
-  const fourthExpected = crypto
-    .createHash('md5')
-    .update('/root/path/baz')
-    .digest('hex');
-
-  const options = normalize(
-    {
-      projects: [
-        {rootDir: firstRootDir},
-        {rootDir: firstRootDir},
-        {rootDir: secondRootDir},
-        {},
-      ],
-      rootDir: '/root/path/baz',
-    },
-    {},
-  );
-
-  expect(options.options.projects[0].name).toBe(firstExpected);
-  expect(options.options.projects[1].name).toBe(secondExpected);
-  expect(options.options.projects[2].name).toBe(thirdExpected);
-  expect(options.options.projects[3].name).toBe(fourthExpected);
-});
-
 it('keeps custom project name based on the projects rootDir', () => {
   const name = 'test';
   const options = normalize(

packages/jest-config/src/index.js

@@ -86,7 +86,12 @@ export function readConfig(
     rawOptions = readConfigFileAndSetRootDir(configPath);
   }
 
-  const {options, hasDeprecationWarnings} = normalize(rawOptions, argv);
+  const {options, hasDeprecationWarnings} = normalize(
+    rawOptions,
+    argv,
+    configPath,
+  );
+
   const {globalConfig, projectConfig} = groupOptions(options);
   return {
     configPath,
@@ -210,7 +215,7 @@ const groupOptions = (
   }),
 });
 
-const ensureNoDuplicateConfigs = (parsedConfigs, projects, rootConfigPath) => {
+const ensureNoDuplicateConfigs = (parsedConfigs, projects) => {
   const configPathMap = new Map();
 
   for (const config of parsedConfigs) {
@@ -299,7 +304,7 @@ export function readConfigs(
       })
       .map(root => readConfig(argv, root, true, configPath));
 
-    ensureNoDuplicateConfigs(parsedConfigs, projects, configPath);
+    ensureNoDuplicateConfigs(parsedConfigs, projects);
     configs = parsedConfigs.map(({projectConfig}) => projectConfig);
     if (!hasDeprecationWarnings) {
       hasDeprecationWarnings = parsedConfigs.some(

packages/jest-config/src/normalize.js

@@ -13,6 +13,7 @@ import type {
   DefaultOptions,
   ReporterConfig,
   GlobalConfig,
+  Path,
   ProjectConfig,
 } from 'types/Config';
 
@@ -263,34 +264,19 @@ const normalizePreprocessor = (options: InitialOptions): InitialOptions => {
   return options;
 };
 
-const normalizeMissingOptions = (options: InitialOptions): InitialOptions => {
-  const knownRootDirs: Set<string> = new Set();
+const normalizeMissingOptions = (
+  options: InitialOptions,
+  configPath: ?Path,
+): InitialOptions => {
   if (!options.name) {
     options.name = crypto
       .createHash('md5')
       .update(options.rootDir)
+      // In case we load config from some path that has the same root dir
+      .update(configPath || '')
       .digest('hex');
   }
 
-  if (Array.isArray(options.projects)) {
-    options.projects = options.projects.map((project, index) => {
-      if (typeof project !== 'string' && !project.name) {
-        let rootDir = project.rootDir || options.rootDir;
-        if (knownRootDirs.has(rootDir)) {
-          rootDir = `${rootDir}:${index}`;
-        }
-
-        knownRootDirs.add(rootDir);
-        project.name = crypto
-          .createHash('md5')
-          .update(rootDir)
-          .digest('hex');
-      }
-
-      return project;
-    });
-  }
-
   if (!options.setupFiles) {
     options.setupFiles = [];
   }
@@ -393,7 +379,11 @@ const showTestPathPatternError = (testPathPattern: string) => {
   );
 };
 
-export default function normalize(options: InitialOptions, argv: Argv) {
+export default function normalize(
+  options: InitialOptions,
+  argv: Argv,
+  configPath: ?Path,
+) {
   const {hasDeprecationWarnings} = validate(options, {
     comment: DOCUMENTATION_NOTE,
     deprecatedConfig: DEPRECATED_CONFIG,
@@ -412,7 +402,10 @@ export default function normalize(options: InitialOptions, argv: Argv) {
 
   options = normalizePreprocessor(
     normalizeReporters(
-      normalizeMissingOptions(normalizeRootDir(setFromArgv(options, argv))),
+      normalizeMissingOptions(
+        normalizeRootDir(setFromArgv(options, argv)),
+        configPath,
+      ),
     ),
   );