-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): add directory details to the package.json of all packages #7649
Conversation
Specifying the directory as part of the `repository` field in a `package.json` allows third party tools to provide better support when working with monorepos. For example, it allows them to correctly construct a commit diff for a specific package. This format was accepted by npm in npm/rfcs#19.
Nice! Is this something yarn will support as well? I don't see it mentioned in the RFC (/cc @arcanis). |
Not sure - might be useful to Yarn, but the main use cases I had in mind when writing were:
Can imagine there are other use cases where knowing where something lives within a monorepo is also useful, though! |
Codecov Report
@@ Coverage Diff @@
## master #7649 +/- ##
=======================================
Coverage 68.28% 68.28%
=======================================
Files 250 250
Lines 9627 9627
Branches 5 5
=======================================
Hits 6574 6574
Misses 3051 3051
Partials 2 2 Continue to review full report at Codecov.
|
Yeah, that's the same thing https://yarnpkg.com would do, I'd hope. And yarn's website is open source, so should be possible to PR it 🙂 https://github.com/yarnpkg/website |
Oh nice! Will PR it 🙂 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Specifying the directory as part of the
repository
field in apackage.json
allows npm and third party tools to provide better support when working with monorepos. For example, it allows them to correctly construct a commit diff for a specific package.This format was accepted by npm in npm/rfcs#19.