Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix watch plugins link #7638

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Fix watch plugins link #7638

merged 1 commit into from
Jan 16, 2019

Conversation

vitaliyazvinski
Copy link
Contributor

The current link leads me to 404

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@SimenB
Copy link
Member

SimenB commented Jan 16, 2019

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@vitaliyazvinski
Copy link
Contributor Author

@SimenB

Mind updateing >https://github.com/facebook/jest/blob/c22d9f584627a1ae6c476d44f10c3c186b480722/website/versioned_docs/version-23.6/Configuration.md as well?

I would be happy to update it too but there's no WatchPlugins.md in "version-23.6"

@SimenB
Copy link
Member

SimenB commented Jan 16, 2019

Oh, you're clicking around in the source code? In that case, no need to updated the versioned one 🙂

Both links currently work correctly on the deployed website:

However, since they still work after this PR (you can check out the Netlify deploy) this should be fine to merge. Thanks!

@SimenB SimenB merged commit 45f5498 into jestjs:master Jan 16, 2019
@vitaliyazvinski
Copy link
Contributor Author

vitaliyazvinski commented Jan 16, 2019

Oh, you're clicking around in the source code?

Right.
Yes, on the website they work fine.
Thanks

SimenB added a commit that referenced this pull request Jan 16, 2019
@SimenB
Copy link
Member

SimenB commented Jan 16, 2019

Had to revert this, it broke all translations. Not sure why... #7639

Opened up facebook/docusaurus#1188

captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants