-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix watch plugins link #7638
Fix watch plugins link #7638
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thanks! Mind updateing https://github.com/facebook/jest/blob/c22d9f584627a1ae6c476d44f10c3c186b480722/website/versioned_docs/version-23.6/Configuration.md as well? (and sign the CLA 🙂) |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I would be happy to update it too but there's no WatchPlugins.md in "version-23.6" |
Oh, you're clicking around in the source code? In that case, no need to updated the versioned one 🙂 Both links currently work correctly on the deployed website:
However, since they still work after this PR (you can check out the Netlify deploy) this should be fine to merge. Thanks! |
Right. |
Had to revert this, it broke all translations. Not sure why... #7639 Opened up facebook/docusaurus#1188 |
This reverts commit 45f5498.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The current link leads me to 404