Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dot-reporter instead of silent-reporter on CI #6653

Merged
merged 4 commits into from
Jul 7, 2018

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented Jul 7, 2018

Summary

EDIT: let's switch to dot reporter instead of silent, cc @rickhanlonii.

Our test suite is getting heavier and since we're using jest-silent-reporter, Travis detects it as stalled build (10 mins of inactive output) and fails the build. Added travis_wait to extend this period to 20 mins. See their docs for details: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

I think we should explore running tests concurrently on CI to speed them up.

Test plan

@SimenB
Copy link
Member

SimenB commented Jul 7, 2018

We need the same for Circle, it has the same 10 minute timeout

@thymikee
Copy link
Collaborator Author

thymikee commented Jul 7, 2018

Or maybe use some kind of dot reporter instead of silent ¯_(ツ)_/¯

@SimenB
Copy link
Member

SimenB commented Jul 7, 2018

I'd prefer that actually - it's nice seeing the progress

@thymikee
Copy link
Collaborator Author

thymikee commented Jul 7, 2018

Took one from the wild, looks ok locally. Let's see it on CI

@thymikee thymikee changed the title Make travis wait 20mins instead of 10 for no output Use dot-reporter instead of silent-reporter on CI Jul 7, 2018
@thymikee
Copy link
Collaborator Author

thymikee commented Jul 7, 2018

Looks silly on Circle 😄

screen shot 2018-07-07 at 19 08 56

and it doesn't output anything on Travis 🤔

@SimenB
Copy link
Member

SimenB commented Jul 7, 2018

Yeah, not the best I've ever seen :P

@SimenB
Copy link
Member

SimenB commented Jul 7, 2018

Crazy line wrap, but should be fine

@thymikee
Copy link
Collaborator Author

thymikee commented Jul 7, 2018

Yay! This one works on Travis :)

@codecov-io
Copy link

Codecov Report

Merging #6653 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6653   +/-   ##
=======================================
  Coverage   63.73%   63.73%           
=======================================
  Files         235      235           
  Lines        8940     8940           
  Branches        3        3           
=======================================
  Hits         5698     5698           
  Misses       3241     3241           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff44548...23e2026. Read the comment docs.

@thymikee thymikee requested a review from rickhanlonii July 7, 2018 18:50
@cpojer cpojer merged commit 5a0e661 into jestjs:master Jul 7, 2018
@thymikee thymikee deleted the chore/travis-wait branch March 16, 2019 10:56
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants