-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[babel-plugin-jest-hoist] Fix MockNativeMethods access in react-native #6505
Conversation
Might adding a changelog and updating an e2e test? |
@@ -110,7 +110,7 @@ FUNCTIONS.mock = args => { | |||
if (!found) { | |||
invariant( | |||
(scope.hasGlobal(name) && WHITELISTED_IDENTIFIERS[name]) || | |||
/^mock/.test(name) || | |||
/^[Mm]ock/.test(name) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/^mock/i
? MOCK_THING
should be fine as well, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also update the message on line 126
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments
@@ -71,7 +71,7 @@ const WHITELISTED_IDENTIFIERS = { | |||
}; | |||
Object.keys(global).forEach(name => (WHITELISTED_IDENTIFIERS[name] = true)); | |||
|
|||
const JEST_GLOBAL = {name: 'jest'}; | |||
const JEST_GLOBAL = { name: 'jest' }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your IDE autoformatted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I guess is this one https://github.com/facebook/jest/blob/master/.vscode/settings.json#L8
Reverted.
Codecov Report
@@ Coverage Diff @@
## master #6505 +/- ##
=======================================
Coverage 63.48% 63.48%
=======================================
Files 227 227
Lines 8697 8697
Branches 3 3
=======================================
Hits 5521 5521
Misses 3175 3175
Partials 1 1 Continue to review full report at Codecov.
|
are we able to install that? can't run tests under react-native 0.56 without that :-/ refering to a commit-url in package.json does not work unfortunatly |
When will this be released? |
👌🏻 Let me know when you want the release to be done and we'll make it 🙂 |
You can land #6523 and do it? 😀 |
#6523 is b0rken, is it OK to land? |
Yeah, CI was fixed after that was opened in #6532 |
Roger that! |
This Pull Request updates dependency [jest](https://github.com/facebook/jest) from `v23.1.0` to `v23.2.0` <details> <summary>Release Notes</summary> ### [`v23.2.0`](https://github.com/facebook/jest/blob/master/CHANGELOG.md#​2320) [Compare Source](jestjs/jest@v23.1.0...v23.2.0) ##### Features - `[jest-each]` Add support for keyPaths in test titles ([#​6457](`https://github.com/facebook/jest/pull/6457`)) - `[jest-cli]` Add `jest --init` option that generates a basic configuration file with a short description for each option ([#​6442](`https://github.com/facebook/jest/pull/6442`)) - `[jest.retryTimes]` Add `jest.retryTimes()` option that allows failed tests to be retried n-times when using jest-circus. ([#​6498](`https://github.com/facebook/jest/pull/6498`)) ##### Fixes - `[jest-cli]` Add check to make sure one or more tests have run before notifying when using `--notify` ([#​6495](`https://github.com/facebook/jest/pull/6495`)) - `[jest-cli]` Pass `globalConfig` as a parameter to `globalSetup` and `globalTeardown` functions ([#​6486](`https://github.com/facebook/jest/pull/6486`)) - `[jest-config]` Add missing options to the `defaults` object ([#​6428](`https://github.com/facebook/jest/pull/6428`)) - `[expect]` Using symbolic property names in arrays no longer causes the `toEqual` matcher to fail ([#​6391](`https://github.com/facebook/jest/pull/6391`)) - `[expect]` `toEqual` no longer tries to compare non-enumerable symbolic properties, to be consistent with non-symbolic properties. ([#​6398](`https://github.com/facebook/jest/pull/6398`)) - `[jest-util]` `console.timeEnd` now properly log elapsed time in milliseconds. ([#​6456](`https://github.com/facebook/jest/pull/6456`)) - `[jest-mock]` Fix `MockNativeMethods` access in react-native `jest.mock()` ([#​6505](`https://github.com/facebook/jest/pull/6505`)) ##### Chore & Maintenance - `[docs]` Add jest-each docs for 1 dimensional arrays ([#​6444](`https://github.com/facebook/jest/pull/6444`/files)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
Tests have started failing (see [Build #699](https://travis-ci.org/okta/okta-oidc-js/builds/401943311)). I tried upgrading the jest and/or the babel plugins, per these threads: facebook/react-native#19859 jestjs/jest#6505 But I didn't have any luck. Locking to the 0.55 series of react-ntaive does seeem to fix this problem
Tests have started failing (see [Build #699](https://travis-ci.org/okta/okta-oidc-js/builds/401943311)). I tried upgrading the jest and/or the babel plugins, per these threads: facebook/react-native#19859 jestjs/jest#6505 But I didn't have any luck. Locking to the 0.55 series of react-native does seem to fix this problem
Is this fixed? I'm still getting the error with Jest 23.4.1. UPDATE: I needed to make sure Babel-jest was up to date to inherit this. |
Tests have started failing (see [Build #699](https://travis-ci.org/okta/okta-oidc-js/builds/401943311)). I tried upgrading the jest and/or the babel plugins, per these threads: facebook/react-native#19859 jestjs/jest#6505 But I didn't have any luck. Locking to the 0.55 series of react-native does seem to fix this problem
Tests have started failing (see [Build #699](https://travis-ci.org/okta/okta-oidc-js/builds/401943311)). I tried upgrading the jest and/or the babel plugins, per these threads: facebook/react-native#19859 jestjs/jest#6505 But I didn't have any luck. Locking to the 0.55 series of react-native does seem to fix this problem
Tests have started failing (see [Build #699](https://travis-ci.org/okta/okta-oidc-js/builds/401943311)). I tried upgrading the jest and/or the babel plugins, per these threads: facebook/react-native#19859 jestjs/jest#6505 But I didn't have any luck. Locking to the 0.55 series of react-native does seem to fix this problem
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fix facebook/react-native#19120
Fix #6504
Test plan
/e2e/babel-plugin-jest-hoist/__tests__/integration.test.js