Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Travis only on PRs #6307

Merged
merged 8 commits into from
May 27, 2018
Merged

Build Travis only on PRs #6307

merged 8 commits into from
May 27, 2018

Conversation

thymikee
Copy link
Collaborator

Summary

master is always red because Travis does weird things to TTY there. The issue is not present on branches though, so I think it makes sense now to build only on PRs.

Test plan

Faster builds and green CI

@thymikee thymikee closed this May 27, 2018
@thymikee thymikee reopened this May 27, 2018
@thymikee
Copy link
Collaborator Author

thymikee commented May 27, 2018

Disabled building on branches and enabled pull requests in Travis settings panel.
Turns out PRs are built on master, so I cannot disable it through config.

@thymikee thymikee changed the title Don't build Travis on master; try running in parallel Build Travis only on PRs May 27, 2018
@thymikee thymikee requested a review from SimenB May 27, 2018 10:35
@codecov-io
Copy link

codecov-io commented May 27, 2018

Codecov Report

Merging #6307 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6307      +/-   ##
==========================================
- Coverage   63.65%   63.29%   -0.36%     
==========================================
  Files         225      222       -3     
  Lines        8626     8542      -84     
  Branches        3        3              
==========================================
- Hits         5491     5407      -84     
  Misses       3134     3134              
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-each/src/array.js
packages/jest-each/src/index.js
packages/jest-each/src/template.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8816df7...2528c45. Read the comment docs.

@thymikee thymikee merged commit 3a3b4e3 into jestjs:master May 27, 2018
@thymikee thymikee deleted the feat/ci2 branch May 27, 2018 11:12
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants