Legacy execution order #6100
Closed
Legacy execution order #6100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niieani
force-pushed
the
legacy-execution-order
branch
from
41ebd5d to
2a4733d
Compare
…documented execution order We do not set the currentDeclarationSuite upon node start in order to keep a legacy, undocumented ordering of beforeEach execution. Specifically, this applies to beforeEach that were added inside of tests. Facebook depends on this behavior internally (see jestjs#5964 for discussion) Also: Added type of CreateOptions in jasmine_light Added legacyExecutionOrder: false to DEFAULT_PROJECT_CONFIG Updated test snapshots
niieani
force-pushed
the
legacy-execution-order
branch
from
2a4733d to
31780cd
Compare
This was referenced May 1, 2018
|
Not needed after #6177 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6098
Summary
Facebook internally depended on undocumented execution order.
The order used to be less intuitive (IMO), as
beforeAllscheduled inside of tests would go BEFORE thebeforeAllscheduled inside the suite. It is now possible to restore that order by switching on the flaglegacyExecutionOrder: truein jest's project configuration.Keeping this undocumented on purpose.
Test plan
@mjesun added a test, I've added another one for the flag turned off.