Upgrade deps and include examples in workspaces #6090
Conversation
| @@ -1,9 +0,0 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
There was a problem hiding this comment.
Looks like this was added to the source by accident
There was a problem hiding this comment.
this usually happens if a test run is interrupted. I wonder if we should go through and add all the files we write and then remove from disk to .gitignore to avoid accidentally committing them
Codecov Report
@@ Coverage Diff @@
## master #6090 +/- ##
======================================
Coverage 64.1% 64.1%
======================================
Files 217 217
Lines 8335 8335
Branches 4 3 -1
======================================
Hits 5343 5343
Misses 2991 2991
Partials 1 1Continue to review full report at Codecov.
|
|
I think you have to make all the examples
My guess is because they were not in the workspace. Now that they are, we can probably get rid of them from the root. |
|
Yep, makes sense to move them to correct deps with this PR, or later. For now I've removed "enzyme", "react" and "immutable" from root package.json. I believe it makes things less confusing for anyone updating examples or |
|
Cool, thanks for the cleanup. This is much better. I think I had to do things the way they were done for some Jest or Yarn related symlinking issues. Given that the tests still pass, this is way better. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
yarn upgrade-interactive.I'm not sure why only RN example was included in Yarn workspaces, so I've added all the projects.
Also, what's the rationale for having dependencies from examples declared in root
package.json? Since we use workspaces now it doesn't seem necessary at all, but maybe I'm missing something.Closes #6092 (obsolete)
Test plan
CI